Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add support for Python 3.10 #99

Merged
merged 5 commits into from Nov 25, 2022
Merged

✨ Add support for Python 3.10 #99

merged 5 commits into from Nov 25, 2022

Conversation

tiangolo
Copy link
Owner

@tiangolo tiangolo commented Oct 26, 2021

✨ Add support for Python 3.10

This will have to wait until Uvicorn requires httptools 0.3.0 with support for Python 3.10 https://github.com/MagicStack/httptools/releases/tag/v0.3.0

@hingston
Copy link

hingston commented Jan 15, 2022

#111 will allow this to build. Once installing gcc for python-slim image I can build all 3.10 images successfully.

@skraus-dev
Copy link

skraus-dev commented Feb 2, 2022

Is it an option to pin httptools version requirement ourselves to httptools>=0.3.0 ?

Uvicorn defines it in such boundaries where this should possible.

https://github.com/encode/uvicorn/blob/efdbe7a4a6c94f34c35d751fb63391136b4e90e4/setup.py#L54-L57

extra_requirements = [
    "websockets>=10.0",
    "httptools>=0.2.0,<0.4.0",
    "uvloop>=0.14.0,!=0.15.0,!=0.15.1; " + env_marker_cpython,

EDIT: Indeed! This is only possible since 8.11.2021, when uvicorn changed the version pinning for httptools: encode/uvicorn#1243

@deshetti
Copy link

Hi @tiangolo , wanted to check if there is anything pending for this PR to be merged? I will try taking a shot at it, if anything else is required for this to complete. Thanks.

@thiagosalvatore
Copy link

thiagosalvatore commented Feb 22, 2022

Hey @tiangolo, any updates here? I'm planning to update my app to use python 3.10 and this release would help a lot

@pmarcelll
Copy link

uvicorn 0.17.6 now requires httptools 0.4.0, so this is not blocked anymore (or at least we're one step closer to being unblocked).

@SionAbes
Copy link

This looks like it can be re-run, though an update to 0.17.6 as mentioned by dependabot would be needed! Looking forward to the performance increases on MacOS! ✨⚡️

@padauer
Copy link

padauer commented May 6, 2022

@tiangolo uvicorn bumped httptools in march to >=0.4.0. see: encode/uvicorn#1400
could you please provide support for python 3.10?

@sylvainmouquet
Copy link

the project is still maintained ?

@AlTosterino
Copy link

Just bumping 🙌

@tienhm0202
Copy link

Bump as well

@MarlieChiller
Copy link

bump!

1 similar comment
@bazylhorsey
Copy link

bump!

@karamfil
Copy link

Hey @tiangolo, is there a timeline for this change?

@agates4
Copy link

agates4 commented Nov 18, 2022

Looking forward to this change

@tiangolo tiangolo merged commit 8875d10 into master Nov 25, 2022
@tiangolo tiangolo deleted the python3.10 branch November 25, 2022 12:23
@tiangolo
Copy link
Owner Author

Done! 🚀 🎉

Thanks for the input everyone! 🍰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet