Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Add StrEnum example for python 3.11+ #745

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Matthieu-LAURENT39
Copy link

Python 3.11 added StrEnum, that can replace using MyEnum(str, Enum).

This adds that usage to the Enum parameter type docs, while also keeping the old usage for users on older versions of Python.

Copy link

github-actions bot commented Mar 1, 2024

📝 Docs preview for commit 7bd4597 at: https://af13581c.typertiangolo.pages.dev

@svlandeg svlandeg added docs Improvements or additions to documentation p3 labels Mar 1, 2024
@svlandeg svlandeg marked this pull request as draft March 29, 2024 10:13
@svlandeg
Copy link
Collaborator

svlandeg commented Mar 29, 2024

Thanks for the contribution! I'll update this with master and add a test to double check the behaviour 🙏

[UPDATE] something seems up with the docs-building part of the CI (unrelated to this PR) - we'll look into that first.

[UPDATE 2] CI fixed 😎

@svlandeg svlandeg changed the title Add StrEnum example for python 3.11+ 📝 Add StrEnum example for python 3.11+ Apr 2, 2024
Copy link

github-actions bot commented Apr 2, 2024

📝 Docs preview for commit ec692a6 at: https://ac610b93.typertiangolo.pages.dev

Copy link

github-actions bot commented Apr 2, 2024

📝 Docs preview for commit 918563e at: https://a59ac027.typertiangolo.pages.dev

@svlandeg
Copy link
Collaborator

svlandeg commented Apr 3, 2024

Quick update: we'll pause this PR for a bit, as we want to put a mechanism in place first to have source examples for different Python versions, as well as corresponding tests that require specific Python versions too. We'll get back to this PR once we've taken care of that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation p3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants