Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Fix import of get_terminal_size for click 8.1.0 support and upgrade Black for CI #380

Merged
merged 3 commits into from Mar 30, 2022

Conversation

tiangolo
Copy link
Owner

馃悰 Fix import of get_terminal_size for click 8.1.0 support and upgrade Black for CI

Continuation of #375 handling CI.

@github-actions
Copy link

@github-actions
Copy link

馃摑 Docs preview for commit 60145d9 at: https://62448dee3f7d8c00659ebaa1--typertiangolo.netlify.app

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #380 (60145d9) into master (6d8e954) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #380   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          252       252           
  Lines         5287      5287           
=========================================
  Hits          5287      5287           
Impacted Files Coverage 螖
docs_src/commands/callback/tutorial004.py 100.00% <酶> (酶)
tests/test_completion/test_completion_install.py 100.00% <100.00%> (酶)
tests/__init__.py 100.00% <0.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 6d8e954...60145d9. Read the comment docs.

Copy link
Contributor

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny the lint CI failed due to the same issue :) LGTM. Thanks for taking the time!

@zanieb zanieb mentioned this pull request Mar 30, 2022
@henryiii
Copy link

Black is affected by a different removal from click 8.1 (one that started with an underscore!), but similar.

@tiangolo tiangolo merged commit 9910f38 into master Mar 30, 2022
@tiangolo tiangolo deleted the click-8-1-0-black branch March 30, 2022 19:11
@tiangolo
Copy link
Owner Author

Thanks for the initial work/PR @madkinsz! And thanks for the feedback @henryiii!

This will be available in Typer 0.4.1, released in the next hour. 馃殌 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants