Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH Actions by removing broken poetry-version-plugin and dropping python 3.6 support #602

Closed
wants to merge 11 commits into from

Conversation

SimonCW
Copy link
Contributor

@SimonCW SimonCW commented May 31, 2023

Hey @tiangolo, this fixes the GH Action Jobs and, hence, unblocks development. I tried to stick to strictly necessary changes in order to keep this PR small.

Changes:

I'm setting the __version__ dynamically as outlined here: https://stackoverflow.com/a/67097076/6663432 . I'm not 100% certain that this works as intended everywhere.

@SimonCW
Copy link
Contributor Author

SimonCW commented May 31, 2023

The version-plugin doesn't work, see tiangolo/poetry-version-plugin#28

@SimonCW
Copy link
Contributor Author

SimonCW commented May 31, 2023

I think one way forward would be to switch sqlmodel to the hatchling build-backend just as fastapi. The backend would provide the versioning without the broken poetry backend and maintenance effort for @tiangolo would be reduced by using a similar setup in sqlmodel and fastapi.

I might try to migrate sqlmodel to hatchling, but I'm very short on time, atm, and I don't have experience with build-backends.

@github-actions
Copy link

📝 Docs preview for commit 068c871 at: https://6477a3b554df5e08a6cc632e--sqlmodel.netlify.app

@github-actions
Copy link

📝 Docs preview for commit 3ac39b2 at: https://6477aa124877fa0c3bab4a94--sqlmodel.netlify.app

@github-actions
Copy link

📝 Docs preview for commit a72e284 at: https://6477adc78f64150f631c469d--sqlmodel.netlify.app

@github-actions
Copy link

📝 Docs preview for commit 06deba8 at: https://6477aff64c30060b290484b9--sqlmodel.netlify.app

@github-actions
Copy link

📝 Docs preview for commit a708162 at: https://6477b0c913da53126c3b476a--sqlmodel.netlify.app

@github-actions
Copy link

📝 Docs preview for commit 79069b5 at: https://6477b1ec165cac12885ed06b--sqlmodel.netlify.app

@github-actions
Copy link

📝 Docs preview for commit 4c3afc7 at: https://6477b67a5c5ca115fc91a4f9--sqlmodel.netlify.app

@SimonCW SimonCW changed the title Try fixing ci job by updating to newer poetry version Fix GH Actions by removing broken poetry-version-plugin and dropping python 3.6 support May 31, 2023
@peterlandry
Copy link
Contributor

I have some time to throw at this, if there's anything specific that could be done to help it land? Happy to look at a Hatch migration if @tiangolo prefers.

@tiangolo
Copy link
Owner

Thank you @SimonCW! I wanted to update the poetry-version-plugin first. I might consider moving to Hatch, but for now it's fine. 🤓

As this has several conflicts now and the main problem was solved in another PR, I'll pass on this one, but thanks for the effort! ☕

@tiangolo tiangolo closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants