Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Korean translation for docs/ko/docs/benchmarks.md and docs/ko/docs/tutorial/testing.md #9496

Closed
wants to merge 8 commits into from

Conversation

ElliottLarsen
Copy link
Contributor

@ElliottLarsen ElliottLarsen commented May 8, 2023

Add Korean translation for docs/ko/docs/tutorial/testing.md
Related to Korean translations #2017

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

📝 Docs preview for commit 78ccdad at: https://6458513b0eaef4437c328204--fastapi.netlify.app

@tiangolo tiangolo changed the title Add Korean translation for docs/ko/docs/tutorial/testing.md 🌐 Add Korean translation for docs/ko/docs/tutorial/testing.md May 8, 2023
@tiangolo tiangolo added lang-all Translations awaiting-review lang-ko Korean translations labels May 8, 2023
@github-actions
Copy link
Contributor

📝 Docs preview for commit a65df6c at: https://645c6233cd50eb31e037daef--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 6200aa5 at: https://64683938af410b4b08767d29--fastapi.netlify.app

Merge from FastAPI Master
@github-actions
Copy link
Contributor

📝 Docs preview for commit 76c83b9 at: https://64754e2fcc50357aa66b20cf--fastapi.netlify.app

@tiangolo
Copy link
Owner

📝 Docs preview for commit 7649bc4 at: https://649a2e6797baca1ed99aa0bf--fastapi.netlify.app

@tiangolo tiangolo changed the title 🌐 Add Korean translation for docs/ko/docs/tutorial/testing.md 🌐 Add Korean translation for docs/ko/docs/benchmarks.md and docs/ko/docs/tutorial/testing.md Jun 27, 2023
@joonas-yoon
Copy link
Contributor

Thanks for your work. I'm not sure about two document changes at one PR. I think it would be seperated.

@hard-coders
Copy link
Sponsor Contributor

You have to separate it. Close the PR and open it again 😿

@tiangolo
Copy link
Owner

It would be better to do this in 2 PRs, that way others would be able to review and approve one file and I could merge it. We could do that and continue gradually. 🤓

For now, I'll close this one. But feel free to create 2 new PRs (or anyone else that sees this, feel free to copy the contents and start a new PR with it, or start over, as the original might have changed a bit). ☕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-all Translations lang-ko Korean translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants