Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NoneType return type for 204 endpoints #5860

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
+6 −1
Open

Fix NoneType return type for 204 endpoints #5860

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
151bf3e
Fix `NoneType` return type for 204 endpoints
matiuszka Jan 9, 2023
2fb954e
fixup! Fix `NoneType` return type for 204 endpoints
matiuszka Jan 9, 2023
fd1e651
fixup! Fix `NoneType` return type for 204 endpoints
matiuszka Jan 9, 2023
e1843d0
fixup! Fix `NoneType` return type for 204 endpoints
matiuszka Jan 9, 2023
d0a6d46
🎨 [pre-commit.ci] Auto format from pre-commit.com hooks
pre-commit-ci[bot] Jan 9, 2023
7748aa2
Merge branch 'master' into fix-typed-annotations-for-none-type
alejsdev Jan 15, 2024
f8e0f9d
Merge branch 'master' into fix-typed-annotations-for-none-type
matiuszka Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion fastapi/dependencies/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,12 @@ def get_typed_return_annotation(call: Callable[..., Any]) -> Any:
return None

globalns = getattr(call, "__globals__", {})
return get_typed_annotation(annotation, globalns)
typed_annotation = get_typed_annotation(annotation, globalns)

if typed_annotation is type(None): # noqa: E721
return None

return typed_annotation


def get_dependant(
Expand Down