Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrade Ruff #5698

Merged
merged 6 commits into from Nov 27, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Expand Up @@ -19,7 +19,7 @@ repos:
- --py3-plus
- --keep-runtime-typing
- repo: https://github.com/charliermarsh/ruff-pre-commit
rev: v0.0.114
rev: v0.0.138
hooks:
- id: ruff
args:
Expand Down
4 changes: 2 additions & 2 deletions fastapi/dependencies/utils.py
Expand Up @@ -105,10 +105,10 @@ def check_file_field(field: ModelField) -> None:
assert parse_options_header
except ImportError:
logger.error(multipart_incorrect_install_error)
raise RuntimeError(multipart_incorrect_install_error)
raise RuntimeError(multipart_incorrect_install_error) from None
except ImportError:
logger.error(multipart_not_installed_error)
raise RuntimeError(multipart_not_installed_error)
raise RuntimeError(multipart_not_installed_error) from None


def get_param_sub_dependant(
Expand Down
2 changes: 1 addition & 1 deletion fastapi/encoders.py
Expand Up @@ -157,7 +157,7 @@ def jsonable_encoder(
data = vars(obj)
except Exception as e:
errors.append(e)
raise ValueError(errors)
raise ValueError(errors) from e
return jsonable_encoder(
data,
include=include,
Expand Down
2 changes: 1 addition & 1 deletion fastapi/utils.py
Expand Up @@ -89,7 +89,7 @@ def create_response_field(
except RuntimeError:
raise fastapi.exceptions.FastAPIError(
f"Invalid args for response field! Hint: check that {type_} is a valid pydantic field type"
)
) from None


def create_cloned_field(
Expand Down
8 changes: 5 additions & 3 deletions pyproject.toml
Expand Up @@ -53,7 +53,7 @@ test = [
"pytest >=7.1.3,<8.0.0",
"coverage[toml] >= 6.5.0,<7.0",
"mypy ==0.982",
"ruff ==0.0.114",
"ruff ==0.0.138",
"black == 22.10.0",
"isort >=5.0.6,<6.0.0",
"httpx >=0.23.0,<0.24.0",
Expand Down Expand Up @@ -87,7 +87,7 @@ doc = [
"pyyaml >=5.3.1,<7.0.0",
]
dev = [
"ruff ==0.0.114",
"ruff ==0.0.138",
"uvicorn[standard] >=0.12.0,<0.19.0",
"pre-commit >=2.17.0,<3.0.0",
]
Expand Down Expand Up @@ -168,6 +168,7 @@ select = [
ignore = [
"E501", # line too long, handled by black
"B008", # do not perform function calls in argument defaults
"C901", # too complex
]

[tool.ruff.per-file-ignores]
Expand All @@ -178,7 +179,8 @@ ignore = [
"docs_src/dependencies/tutorial010.py" = ["F821"]
"docs_src/custom_response/tutorial007.py" = ["B007"]
"docs_src/dataclasses/tutorial003.py" = ["I001"]

"docs_src/path_operation_advanced_configuration/tutorial007.py" = ["B904"]
"docs_src/custom_request_and_route/tutorial002.py" = ["B904"]

[tool.ruff.isort]
known-third-party = ["fastapi", "pydantic", "starlette"]