✏ Fix grammar and add helpful links to dependencies in docs/en/docs/async.md
#5432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #5432 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 540 540
Lines 13934 13934
=========================================
Hits 13934 13934 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
📝 Docs preview for commit 5f1ab90 at: https://6331a6062ae14413c35f61c6--fastapi.netlify.app |
BilalAlpaslan
approved these changes
Sep 26, 2022
tiangolo
changed the title
docs/en/docs/async.md
tiangolo
changed the title
docs/en/docs/async.mddocs/en/docs/async.md
|
Awesome, thanks for the contribution! ☕ 🍰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a grammar issue (define->defining) and also adds internal links to the description of dependencies. When I was first reading this doc, I didn't know FastAPI had its own concept of dependencies, so I was quite confused upon reading that section. Linking the concepts should help others discover their meaning more quickly.