Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrade mypy and tweak internal type annotations #5398

Merged
merged 3 commits into from Sep 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions fastapi/dependencies/utils.py
Expand Up @@ -426,22 +426,22 @@ def is_coroutine_callable(call: Callable[..., Any]) -> bool:
return inspect.iscoroutinefunction(call)
if inspect.isclass(call):
return False
call = getattr(call, "__call__", None)
return inspect.iscoroutinefunction(call)
dunder_call = getattr(call, "__call__", None)
return inspect.iscoroutinefunction(dunder_call)


def is_async_gen_callable(call: Callable[..., Any]) -> bool:
if inspect.isasyncgenfunction(call):
return True
call = getattr(call, "__call__", None)
return inspect.isasyncgenfunction(call)
dunder_call = getattr(call, "__call__", None)
return inspect.isasyncgenfunction(dunder_call)


def is_gen_callable(call: Callable[..., Any]) -> bool:
if inspect.isgeneratorfunction(call):
return True
call = getattr(call, "__call__", None)
return inspect.isgeneratorfunction(call)
dunder_call = getattr(call, "__call__", None)
return inspect.isgeneratorfunction(dunder_call)


async def solve_generator(
Expand Down
2 changes: 1 addition & 1 deletion fastapi/routing.py
Expand Up @@ -127,7 +127,7 @@ async def serialize_response(
if is_coroutine:
value, errors_ = field.validate(response_content, {}, loc=("response",))
else:
value, errors_ = await run_in_threadpool( # type: ignore[misc]
value, errors_ = await run_in_threadpool(
field.validate, response_content, {}, loc=("response",)
)
if isinstance(errors_, ErrorWrapper):
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Expand Up @@ -51,7 +51,7 @@ Documentation = "https://fastapi.tiangolo.com/"
test = [
"pytest >=7.1.3,<8.0.0",
"pytest-cov >=2.12.0,<4.0.0",
"mypy ==0.910",
"mypy ==0.971",
"flake8 >=3.8.3,<6.0.0",
"black == 22.3.0",
"isort >=5.0.6,<6.0.0",
Expand Down