Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆ Upgrade Starlette from 0.19.1 to 0.20.4 #5355

Closed
wants to merge 4 commits into from

Conversation

SogoKato
Copy link

@SogoKato SogoKato commented Sep 7, 2022

Summary

  • Upgrade starlette from 0.19.1 to 0.20.4

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

📝 Docs preview for commit 2b1f793 at: https://63183f2adc0da768db197cb7--fastapi.netlify.app

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #5355 (3357ed7) into master (3079ba9) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #5355   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          539       539           
  Lines        13906     13911    +5     
=========================================
+ Hits         13906     13911    +5     
Impacted Files Coverage Δ
fastapi/encoders.py 100.00% <ø> (ø)
fastapi/applications.py 100.00% <100.00%> (ø)
fastapi/concurrency.py 100.00% <100.00%> (ø)
fastapi/dependencies/utils.py 100.00% <100.00%> (ø)
fastapi/security/api_key.py 100.00% <100.00%> (ø)
tests/test_route_scope.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

📝 Docs preview for commit 3d887d2 at: https://6318410be6f7d279c8d3717c--fastapi.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

📝 Docs preview for commit 1290b19 at: https://631843891c52746919f75086--fastapi.netlify.app

@iudeen
Copy link
Contributor

iudeen commented Sep 7, 2022

In order to bump starlette version, FastAPI has to drop support for Python 3.6.

Currently FastAPI supports python 3.6.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

📝 Docs preview for commit 3357ed7 at: https://631844ba1040d46dbc28ac95--fastapi.netlify.app

@SogoKato
Copy link
Author

SogoKato commented Sep 7, 2022

In order to bump starlette version, FastAPI has to drop support for Python 3.6.

Currently FastAPI supports python 3.6.

When do you expect to drop support for python 3.6?
It is said that "This is probably the last release (or one of the last releases) to support Python 3.6." in the latest release notes.

@iudeen
Copy link
Contributor

iudeen commented Sep 7, 2022

It's up to the maintainers of the project. I don't have an answer for when it'd be done🙂

@Kludex
Copy link
Sponsor Collaborator

Kludex commented Sep 7, 2022

Also, tiangolo bumps Starlette's version individually, so from 0.19.1 to 0.20.4 there are some steps 😅

@dwinston
Copy link

dwinston commented Sep 8, 2022

I use route paths with colons, so I am pinned to fastapi<0.76.0 for now. I'm glad https://fastapi.tiangolo.com/release-notes/#0820 announced intent of dropping Python 3.6 support.

@SogoKato
Copy link
Author

Now https://github.com/tiangolo/fastapi/releases/tag/0.85.0 is released, I close this p-r.

@SogoKato SogoKato closed this Oct 21, 2022
@tiangolo
Copy link
Owner

tiangolo commented Nov 8, 2022

Thanks for coming back to close the PR @SogoKato ! ☕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants