Specificy a minimum version for flit #5313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we leave the flit version unbound and by change an 1.x or 2.x version is already installed, failures will happen, as an attempt will be done to import flit_core.inifile, which doesn't exist, as there is no flit_core in onder versions.
Codecov Report
@@ Coverage Diff @@
## master #5313 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 535 535
Lines 13825 13825
=========================================
Hits 13825 13825 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
📝 Docs preview for commit d597020 at: https://630c3a28f80c1f4e01140164--fastapi.netlify.app |
|
I think once FastAPI adheres to new build standard defined by PyPa, this PR #5240, this won't be relevant. |
|
I don't know when, but I don't see any blocker except for current support for Python36 at FastAPI side. Once the maintainers decide to drop 3.6 support, I hope the above mentioned PR will be merged. |
|
Thanks! As FastAPI is now built with Hatch, this is no longer necessary. So I'll close it. But thanks for the effort! ☕ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we leave the flit version unbound and by change an 1.x or 2.x version
is already installed, failures will happen, as an attempt will be done
to import flit_core.inifile, which doesn't exist, as there is no
flit_core in onder versions.