Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Japanese translation for docs/ja/docs/advanced/events.md #5270

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

My-MC
Copy link

@My-MC My-MC commented Aug 14, 2022

Relates to #1572

This PR is a translation of docs/ja/docs/advanced/events.md.

I'm Japanese. I like this framework so I translated it.

I am the first PR to this repository. I would appreciate a code review. Please let me know if it has any problems.

@codecov
Copy link

codecov bot commented Aug 14, 2022

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf73051) 100.00% compared to head (bccdd1e) 100.00%.

❗ Current head bccdd1e differs from pull request most recent head c179c23. Consider uploading reports for the commit c179c23 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            master     #5270    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          540       532     -8     
  Lines        13969     13684   -285     
==========================================
- Hits         13969     13684   -285     

see 34 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

📝 Docs preview for commit bccdd1e at: https://62f84a3b4a1d0606dbc73077--fastapi.netlify.app

@My-MC My-MC changed the title Add ja translate advanced events 🌐 Add ja translate advanced events Aug 14, 2022
@My-MC My-MC changed the title 🌐 Add ja translate advanced events 🌐 Add Japanee translate for docs/ja/docs/advanced/events.md Aug 14, 2022
@My-MC My-MC changed the title 🌐 Add Japanee translate for docs/ja/docs/advanced/events.md 🌐 Add Japanese translate for docs/ja/docs/advanced/events.md Aug 14, 2022
@tiangolo tiangolo changed the title 🌐 Add Japanese translate for docs/ja/docs/advanced/events.md 🌐 Add Japanese translation for docs/ja/docs/advanced/events.md Aug 18, 2022
@tiangolo tiangolo added lang-all Translations lang-ja Japanese translations awaiting-review labels Aug 18, 2022
@tiangolo
Copy link
Owner

📝 Docs preview for commit c179c23 at: https://649a1242ec68df0f86e6b2db--fastapi.netlify.app

@tiangolo
Copy link
Owner

Thank you! I'm still waiting for others to review this to be able to merge it, meanwhile, maybe you could help me review some of the other Japanese translations, that way if they are approved by each other, I could merge them. 🤓

https://github.com/tiangolo/fastapi/issues?q=is%3Aopen+label%3Alang-ja+sort%3Aupdated-desc+label%3Aawaiting-review

@codespearhead
Copy link

@My-MC Do you happen to know three Japanese developers that you can ask a PR review from? This might help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review lang-all Translations lang-ja Japanese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants