Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏ Reword and clarify text in tutorial docs/en/docs/tutorial/body-nested-models.md #5169

Merged
merged 1 commit into from Aug 26, 2022

Conversation

papb
Copy link
Contributor

@papb papb commented Jul 18, 2022

It currently says "list of items", and since the entity in the example is called Item, this was a little confusing for me. Avoiding the word "item" in this sentence is probably better.

@github-actions
Copy link
Contributor

📝 Docs preview for commit b9fce4b at: https://62d5ecb7f767f50b8c5fc37a--fastapi.netlify.app

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #5169 (b9fce4b) into master (e35df68) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #5169   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          532       532           
  Lines        13684     13684           
=========================================
  Hits         13684     13684           
Impacted Files Coverage Δ
fastapi/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50fb34b...b9fce4b. Read the comment docs.

Copy link
Contributor

@edisnake edisnake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Contributor

@JarroVGIT JarroVGIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiangolo tiangolo changed the title Minor clarification in body-nested-models tutorial ✏ Reword and clarify text in tutorial docs/en/docs/tutorial/body-nested-models.md Aug 26, 2022
@tiangolo
Copy link
Owner

Great! Good point, thanks @papb! 🚀

@tiangolo tiangolo merged commit 7021346 into tiangolo:master Aug 26, 2022
@papb papb deleted the patch-1 branch August 31, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants