Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏ Fix typos in tests/test_schema_extra_examples.py #5126

Merged
merged 2 commits into from Aug 26, 2022

Conversation

supraaxdd
Copy link
Contributor

While doing a typing test on speedtyper.dev, I got a snippet that had a typo, so decided to drop by and fix it ;)

While doing a typing test on speedtyper.dev, I got a snippet that had a typo, so decided to drop by and fix it ;)
@github-actions
Copy link
Contributor

📝 Docs preview for commit 89fc150 at: https://62cd6d8f1347e4132102d679--fastapi.netlify.app

Copy link

@odiseo0 odiseo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are not passing because in openapi_schema still has some of that 'Qeury' mistake, you have to change them for the tests

@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #5126 (e189fea) into master (bea5194) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #5126   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          532       532           
  Lines        13672     13684   +12     
=========================================
+ Hits         13672     13684   +12     
Impacted Files Coverage Δ
tests/test_schema_extra_examples.py 100.00% <ø> (ø)
fastapi/utils.py 100.00% <0.00%> (ø)
fastapi/routing.py 100.00% <0.00%> (ø)
fastapi/openapi/utils.py 100.00% <0.00%> (ø)
fastapi/openapi/constants.py 100.00% <0.00%> (ø)
tests/test_response_code_no_body.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bea5194...e189fea. Read the comment docs.

@supraaxdd
Copy link
Contributor Author

Okay everything is good to go, thanks for letting me know about the other typos I overlooked!

@github-actions
Copy link
Contributor

📝 Docs preview for commit e189fea at: https://62d1bb4d43a452635297363b--fastapi.netlify.app

Copy link

@odiseo0 odiseo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiangolo tiangolo changed the title 🔧Fixed typos ✏ Fix typos in tests/test_schema_extra_examples.py Aug 26, 2022
@tiangolo
Copy link
Owner

Ha! That's fun, thank you @supraaxdd! 🍰 And thanks everyone for the interactions!

@tiangolo tiangolo merged commit 5e34cb1 into tiangolo:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants