New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✏ Fix typos in tests/test_schema_extra_examples.py
#5126
Conversation
While doing a typing test on speedtyper.dev, I got a snippet that had a typo, so decided to drop by and fix it ;)
📝 Docs preview for commit 89fc150 at: https://62cd6d8f1347e4132102d679--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are not passing because in openapi_schema
still has some of that 'Qeury' mistake, you have to change them for the tests
Codecov Report
@@ Coverage Diff @@
## master #5126 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 532 532
Lines 13672 13684 +12
=========================================
+ Hits 13672 13684 +12
Continue to review full report at Codecov.
|
Okay everything is good to go, thanks for letting me know about the other typos I overlooked! |
📝 Docs preview for commit e189fea at: https://62d1bb4d43a452635297363b--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tests/test_schema_extra_examples.py
Ha! That's fun, thank you @supraaxdd! 🍰 And thanks everyone for the interactions! |
While doing a typing test on speedtyper.dev, I got a snippet that had a typo, so decided to drop by and fix it ;)