Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add ReDoc <noscript> warning when JS is disabled #5074

Merged
merged 3 commits into from Aug 26, 2022

Conversation

evroon
Copy link
Contributor

@evroon evroon commented Jun 24, 2022

Redoc shows a blank page if javascript is disabled.
Using a <noscript> element in the HTML, the user is informed that he/she should enable javascript in order to view the documentation.

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #5074 (c54a593) into master (26c68c6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #5074   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          535       535           
  Lines        13828     13828           
=========================================
  Hits         13828     13828           
Impacted Files Coverage Δ
fastapi/openapi/docs.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

📝 Docs preview for commit d1e87cd at: https://62b56aee02648a4e41674911--fastapi.netlify.app

fastapi/openapi/docs.py Outdated Show resolved Hide resolved
@tiangolo tiangolo changed the title Redoc: add <noscript> warning ✨ Add ReDoc <noscript> warning when JS is disabled Aug 26, 2022
@tiangolo
Copy link
Owner

Cool, thank you @evroon! 🍰

@tiangolo tiangolo enabled auto-merge (squash) August 26, 2022 13:53
@tiangolo tiangolo merged commit de6ccd7 into tiangolo:master Aug 26, 2022
@evroon evroon deleted the add-noscript-to-redoc-html branch August 26, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants