Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃寪 Start of Hebrew translation #5050

Merged
merged 5 commits into from Jul 14, 2022
Merged

馃寪 Start of Hebrew translation #5050

merged 5 commits into from Jul 14, 2022

Conversation

itay-raveh
Copy link
Contributor

@itay-raveh itay-raveh commented Jun 17, 2022

As per the instruction in https://fastapi.tiangolo.com/contributing/#new-language, this PR contains only index.md and the results of running python ./scripts/docs.py new-lang he.

And as per the instructions, I'll be waiting for approval before continuing to more pages :)

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #5050 (54f81e7) into master (f30b6c6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #5050   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          532       532           
  Lines        13684     13684           
=========================================
  Hits         13684     13684           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update f30b6c6...54f81e7. Read the comment docs.

@github-actions
Copy link
Contributor

馃摑 Docs preview for commit 8d332ab at: https://62acf0fed88a0430fa942994--fastapi.netlify.app

@tiangolo tiangolo changed the title Start of Hebrew translation 馃寪 Start of Hebrew translation Jul 14, 2022
@github-actions
Copy link
Contributor

馃摑 Docs preview for commit ad6eb02 at: https://62d04d978504b1005aff319c--fastapi.netlify.app

@tiangolo tiangolo added lang-all Translations lang-he Hebrew translations labels Jul 14, 2022
@tiangolo tiangolo enabled auto-merge (squash) July 14, 2022 17:12
@tiangolo
Copy link
Owner

Awesome, thank you! 馃殌

@tiangolo tiangolo merged commit 59d154f into tiangolo:master Jul 14, 2022
@Idan-Fishman
Copy link

@itay-raveh I would like to assist you with the rest of the pages 馃槃

@itay-raveh
Copy link
Contributor Author

@itay-raveh I would like to assist you with the rest of the pages 馃槃

诪注讜诇讛!

Unsurprisingly, not every word and phrase have perfect Hebrew counterparts. Some can be translated, some transliterated, some it's best to leave as is.

Soon I'll commit a CONTRIBUTING.md file, where we can share our decisions for these words. Hopefully that way we can stay consistent throughout the docs.

Comment here when you start translating a file so we can be in sync :)

JeanArhancet pushed a commit to JeanArhancet/fastapi that referenced this pull request Aug 20, 2022
Co-authored-by: Sebasti谩n Ram铆rez <tiangolo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-all Translations lang-he Hebrew translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants