馃敟 Delete duplicated tests in tests/test_tutorial/test_sql_databases/test_sql_databases.py
#5040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5040 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 532 532
Lines 13672 13666 -6
=========================================
- Hits 13672 13666 -6
Continue to review full report at Codecov.
|
|
馃摑 Docs preview for commit c62484a at: https://62aa949915ad6a1a2c24b021--fastapi.netlify.app |
BilalAlpaslan
approved these changes
Jun 16, 2022
nurettn
approved these changes
Jun 20, 2022
yezz123
approved these changes
Jun 20, 2022
LeSZ0
approved these changes
Jun 29, 2022
iudeen
approved these changes
Jul 14, 2022
|
Ha! Good catch, thank you @raccoonyy! 馃敟 馃嵃 |
tiangolo
changed the title
tests/test_tutorial/test_sql_databases/test_sql_databases.py
tiangolo
changed the title
tests/test_tutorial/test_sql_databases/test_sql_databases.pytests/test_tutorial/test_sql_databases/test_sql_databases.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've read the tests and found duplicated code.
Lines
359~364are exactly the same as the lines353~358.And I can't guess why.