Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐🇵🇱 Add Polish translation for docs/pl/docs/tutorial/first-steps.md #5024

Merged
merged 3 commits into from Jul 14, 2022
Merged

🌐🇵🇱 Add Polish translation for docs/pl/docs/tutorial/first-steps.md #5024

merged 3 commits into from Jul 14, 2022

Conversation

Valaraucoo
Copy link
Contributor

Created docs/pl/tutorial/first-steps.md 🇵🇱 Polish translation.

@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #5024 (f66a6db) into master (8047230) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #5024   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          532       532           
  Lines        13672     13672           
=========================================
  Hits         13672     13672           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8047230...f66a6db. Read the comment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 1e61524 at: https://62a4c5b960f8713f14006fb8--fastapi.netlify.app

Copy link

@BartoszCki BartoszCki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it's OK but there are several places when translations don't feel natural

docs/pl/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/pl/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/pl/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/pl/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/pl/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/pl/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/pl/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/pl/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

📝 Docs preview for commit 4de2218 at: https://62cab1ddc26d32288fb9597b--fastapi.netlify.app

Copy link

@BartoszCki BartoszCki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@github-actions
Copy link
Contributor

📝 Docs preview for commit f66a6db at: https://62cb3c3dd7ab990484238d6d--fastapi.netlify.app

@tiangolo tiangolo added lang-all Translations approved-2 lang-pl Polish translations labels Jul 14, 2022
@tiangolo
Copy link
Owner

Awesome, thank you @Valaraucoo! 🙇

And thanks for the reviews @BartoszCki and @dominikwozniak ! 🍰

@tiangolo tiangolo merged commit 120cf49 into tiangolo:master Jul 14, 2022
JeanArhancet pushed a commit to JeanArhancet/fastapi that referenced this pull request Aug 20, 2022
…tiangolo#5024)

* docs: Polish translation for tutorial/first-steps.md

* docs: Polish translation / fixes after cr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-pl Polish translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants