Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump starlette from 0.20.0 to 0.20.1 #4936

Closed
wants to merge 4 commits into from
Closed

Bump starlette from 0.20.0 to 0.20.1 #4936

wants to merge 4 commits into from

Conversation

Kludex
Copy link
Sponsor Collaborator

@Kludex Kludex commented May 22, 2022 •
edited

Python 3.6 needs to be dropped on #4820 for the pipeline to pass.

@codecov
Copy link

codecov bot commented May 22, 2022 •
edited

Codecov Report

Merging #4936 (0b1b0e3) into master (1876ebc) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##            master    #4936      +/-   ##
===========================================
- Coverage   100.00%   99.98%   -0.02%     
===========================================
  Files          532      532              
  Lines        13672    13673       +1     
===========================================
- Hits         13672    13671       -1     
- Misses           0        2       +2
Impacted Files Coverage Δ
fastapi/applications.py 100.00% <100.00%> (ø)
fastapi/security/api_key.py 100.00% <100.00%> (ø)
fastapi/concurrency.py 90.00% <0.00%> (-10.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1876ebc...0b1b0e3. Read the comment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit da0a234 at: https://628a8d16506abb1780f74f8c--fastapi.netlify.app

@Kludex Kludex changed the title Bump starlette from 0.20.0 to 0.21.0 Bump starlette from 0.20.0 to 0.20.1 May 27, 2022
Kludex
Kludex commented May 28, 2022
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

📝 Docs preview for commit 2851cfd at: https://629278bfb0f7b638d24a92cd--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 0b1b0e3 at: https://62927cae5ebee33521176c42--fastapi.netlify.app

Kludex
Kludex commented May 28, 2022
View reviewed changes
fastapi/security/api_key.py
@@ -27,7 +27,7 @@ def __init__(
self.auto_error = auto_error

async def __call__(self, request: Request) -> Optional[str]:
api_key: str = request.query_params.get(self.model.name)
api_key = request.query_params.get(self.model.name)
Copy link
Sponsor Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

query_params returns the right type now.

@musicinmybrain
Copy link
Contributor

Works as expected when used as a patch in Fedora Rawhide.

@zoola969 zoola969 mentioned this pull request May 31, 2022
Closed
@bodograumann bodograumann mentioned this pull request Jun 8, 2022
Closed
9 tasks
@tiangolo
Copy link
Owner

Thanks! This was solved in #4820, so I'll close this one. ☕

@tiangolo tiangolo closed this Sep 15, 2022
@Kludex Kludex deleted the starlette-master branch June 10, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kludex @musicinmybrain @tiangolo