馃敡 Fix Type hint of auto_error which does not need to be Optional[bool]
#4933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default is True and If someone doesn't want auto_error option, then it should be False instead of None. I guess It is more Pythonic.
Codecov Report
@@ Coverage Diff @@
## master #4933 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 532 532
Lines 13672 13672
=========================================
Hits 13672 13672
Continue to review full report at Codecov.
|
|
馃摑 Docs preview for commit 705b243 at: https://62876934334bfc3cf10a3aaa--fastapi.netlify.app |
DavidKimDY
changed the title
DavidKimDY
changed the title
yezz123
approved these changes
May 20, 2022
tiangolo
changed the title
auto_error which does not need to be Optional[bool]
|
Good catch, thanks @DavidKimDY! 馃殌 馃槑 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default is True and If someone doesn't want auto_error option, then it should be False instead of None.
I guess It is more Pythonic.