✨ Add support in jsonable_encoder for include and exclude with dataclasses
#4923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4923 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 539 539
Lines 13906 13918 +12
=========================================
+ Hits 13906 13918 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
📝 Docs preview for commit d79c13d at: https://628452eb9fe1990e5473d258--fastapi.netlify.app |
JarroVGIT
approved these changes
Jun 30, 2022
|
Thanks! Could you add a couple of tests for it? Probably in |
|
Sure. I'll add it when I have time. |
|
📝 Docs preview for commit ed92464 at: https://63151485063a093c68a88db5--fastapi.netlify.app |
BilalAlpaslan
approved these changes
Sep 7, 2022
tiangolo
changed the title
jsonable_encoder for include and exclude with dataclasses
|
📝 Docs preview for commit 693c8a4 at: https://6319fbeea7f68600ba4ea21d--fastapi.netlify.app |
|
Awesome, thank you @DCsunset! 🚀 🍰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally if the object is a dataclass,
jsonable_encoderwon't respect theincludeandexcludearguments.This PR fixes this issue by applying
jsonable_encoderto the dict of the dataclass.