Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Add tests for required nonable parameters and body fields #4907

Merged
merged 4 commits into from May 14, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
62 changes: 62 additions & 0 deletions tests/test_required_noneable.py
@@ -0,0 +1,62 @@
from typing import Union

from fastapi import Body, FastAPI, Query
from fastapi.testclient import TestClient

app = FastAPI()


@app.get("/query")
def read_query(q: Union[str, None]):
return q


@app.get("/explicit-query")
def read_explicit_query(q: Union[str, None] = Query()):
return q


@app.post("/body-embed")
def send_body_embed(b: Union[str, None] = Body(embed=True)):
return b


client = TestClient(app)


def test_required_nonable_query_invalid():
response = client.get("/query")
assert response.status_code == 422


def test_required_noneable_query_value():
response = client.get("/query", params={"q": "foo"})
assert response.status_code == 200
assert response.json() == "foo"


def test_required_nonable_explicit_query_invalid():
response = client.get("/explicit-query")
assert response.status_code == 422


def test_required_nonable_explicit_query_value():
response = client.get("/explicit-query", params={"q": "foo"})
assert response.status_code == 200
assert response.json() == "foo"


def test_required_nonable_body_embed_no_content():
response = client.post("/body-embed")
assert response.status_code == 422


def test_required_nonable_body_embed_invalid():
response = client.post("/body-embed", json={"invalid": "invalid"})
assert response.status_code == 422


def test_required_noneable_body_embed_value():
response = client.post("/body-embed", json={"b": "foo"})
assert response.status_code == 200
assert response.json() == "foo"