Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Simplify example for docs for Additional Responses, remove unnecessary else #4693

Merged
merged 3 commits into from Aug 26, 2022

Conversation

adriangb
Copy link
Contributor

No description provided.

Copy link
Owner

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is an example source file for the docs, it would require an update in the source docs at additonal-responses.md that use it too, to highlight the new line.

@adriangb
Copy link
Contributor Author

Sorry for the delay, done now @tiangolo

@adriangb adriangb requested a review from tiangolo May 27, 2022 14:42
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #4693 (bfb331c) into master (1876ebc) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #4693   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          532       532           
  Lines        13672     13672           
=========================================
  Hits         13672     13672           
Impacted Files Coverage Δ
docs_src/additional_responses/tutorial001.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1876ebc...bfb331c. Read the comment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit bfb331c at: https://6290e3ece1743000a32bc0ef--fastapi.netlify.app

@tiangolo tiangolo changed the title doc: remove unnecessary else 📝 Simplify example for docs for Additional Responses, remove unnecessary else Aug 26, 2022
@tiangolo
Copy link
Owner

Awesome, thank you @adriangb! 🍰 ☕

@tiangolo tiangolo merged commit dde140d into tiangolo:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants