Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻ Simplify conditional assignment in fastapi/dependencies/utils.py #4597

Merged
merged 2 commits into from Aug 26, 2022
Merged

♻ Simplify conditional assignment in fastapi/dependencies/utils.py #4597

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1420c5a
Remove redundant conditions
Feb 18, 2022
65f9b35
Merge branch 'master' into redundant-condition
tiangolo Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 1 addition & 4 deletions fastapi/dependencies/utils.py
View file
Open in desktop
Expand Up @@ -302,10 +302,7 @@ def get_dependant(
assert is_scalar_field(
field=param_field
), "Path params must be of one of the supported types"
if isinstance(param.default, params.Path):
ignore_default = False
else:
ignore_default = True
ignore_default = not isinstance(param.default, params.Path)
param_field = get_param_field(
param=param,
param_name=param_name,
Expand Down