Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻ Move internal variable for errors in jsonable_encoder to put related code closer #4560

Merged
merged 2 commits into from Aug 26, 2022

Conversation

GuilleQP
Copy link
Contributor

Moved the declaration of errors list to the first except clause in fastapi/encoders.py

@tiangolo tiangolo changed the title Move errors list to relevant block ♻ Move internal variable for errors in jsonable_encoder to put related code closer Aug 26, 2022
@tiangolo
Copy link
Owner

Cool, thanks! ☕

@tiangolo tiangolo enabled auto-merge (squash) August 26, 2022 13:09
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #4560 (a7243dc) into master (75792eb) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #4560   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          535       535           
  Lines        13830     13830           
=========================================
  Hits         13830     13830           
Impacted Files Coverage Δ
fastapi/encoders.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

📝 Docs preview for commit a7243dc at: https://6308c681f898961aa11cce9e--fastapi.netlify.app

@tiangolo tiangolo merged commit a64387c into tiangolo:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants