Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏ Reword to improve legibility of docs about TestClient #4389

Merged
merged 2 commits into from May 10, 2022

Conversation

rgilton
Copy link
Contributor

@rgilton rgilton commented Jan 7, 2022

I find the ordering of this sentence hard to parse -- I'm no scholar
of english grammar, but as a native speaker the current word ordering
feels not quite right.

I find the ordering of this sentence hard to parse -- I'm no scholar
of english grammar, but as a native speaker the current word ordering
feels not quite right.
Copy link

@joakimnordling joakimnordling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiangolo tiangolo changed the title Improve legibility of sentence about instantiating TestClient ✏ Reword to improve legibility of docs about TestClient May 10, 2022
@tiangolo tiangolo enabled auto-merge (squash) May 10, 2022 01:28
@tiangolo
Copy link
Owner

Great, thanks @rgilton! 🔍

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #4389 (3b2e459) into master (3890240) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #4389   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          531       531           
  Lines        13629     13629           
=========================================
  Hits         13629     13629           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3890240...3b2e459. Read the comment docs.

@tiangolo tiangolo merged commit 1233a7d into tiangolo:master May 10, 2022
JeanArhancet pushed a commit to JeanArhancet/fastapi that referenced this pull request Aug 20, 2022
)

Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants