⬆️ Upgrade Starlette to 0.17.1 #4145

simondale00 · 2021-11-04T14:12:57Z

⬆️ Upgrade Starlette to 0.17.0

0.17.0 addresses issue Starlette issue #1255, preventing BaseHTTPMiddleware from raising anyio.ExceptionGroup.

nkamali · 2021-11-04T18:55:48Z

Looks good to me and I'm looking forward to this upgrade for some time. Thank you, @simondale00 for helping with pushing this one forward.

nkamali

lgtm! 👍

simondale00 · 2021-11-08T16:48:01Z

Hey @tiangolo! Curious what additional steps I'll need to take to help get this merged. Thanks in advance!

Kludex · 2021-11-08T17:10:07Z

Just wait.

kevr · 2021-11-09T02:32:44Z

Just wait.

Wait for what?

It's a bit hard to decide what to do at this point.

An MR is up. Wait for the MR to be merged and deal with manual edits to debug things until then.
Depend on a fork of our own or a third party pinned commit.

If the MR is gonna take ten months, then we might as well fork and depend on that. If not, then we would just wait for the new release.

Can we get some type of... idea about the state of this and some sort of rough timeline?

Starlette 0.16.0 has a pretty bad bug in terms of logging which has been fixed in the 0.17.0 release. That being said, FastAPI has not yet merged a request at tiangolo/fastapi#4145 which resolves this dependency resolution so we can use the updated starlette package. kevr has forked the pull request in question and we are using it for now in our poetry dependencies to get ahead of the game. When FastAPI upstream is updated to support 0.17.0, we'll need to switch this back to using upstream's source. Signed-off-by: Kevin Morris <kevr@0cost.org>

Kludex · 2021-11-09T07:02:36Z

No one can give you an estimation, sorry.

The only one with merge rights is @tiangolo , and by the time he sees this PR, he'll probably just merge it.

If you don't want to fork, you can also pin a version predecessor to 0.69 (I'm on my phone, but I think it was 0.68.2).

robertlagrant · 2021-11-09T16:29:12Z

Is it possible to provide a range of versions of Starlette, or is 0.17.0 the absolute minimum?

simondale00 · 2021-11-09T16:31:02Z

Is it possible to provide a range of versions of Starlette, or is 0.17.0 the absolute minimum?

0.17.0 is the absolutely minimum to apply this specific fix, preventing Starlette from raising anyio.ExceptionGroup.

Though to your point, provided that Starlette adheres to semver, it might be more appropriate to pin FastAPI to >=0.17.0,<1.0.0

Kludex · 2021-11-09T16:46:13Z

@simondale00 semver only kicks in after 1.0. That's basically why is pinned here.

@adriangb proposed to have a pipeline that runs periodically against the latest Starlette version (or master), and would auto-merge the pin/range. Maybe we can do something about this, but it's up to @tiangolo . 😗

adriangb · 2021-11-09T16:54:18Z

@adriangb proposed to have a pipeline that runs periodically against the latest Starlette version (or master), and would auto-merge the pin/range

Auto-bumping would be cool!

But I was thinking something much more basic: just running the pipeline and watching it for errors.
That way we can fix smaller issues (instead of fixing the accumulated issues since the last bump), and we'd also have the opportunity to make changes in Starlette before they cut a release.

LarsStegman · 2021-11-17T16:11:13Z

Version 0.17.1 of Starlette has been released, which fixes a bug in the authentication mechanism. I have run into this bug during development. Please use this version instead of 0.17.0.

yezz123 · 2021-11-17T22:13:39Z

I guess there is no problem if everything works smoothly, right now the 0.16.0 do all jobs so waiting for Sebastian to bump the to the last version of starlette 🌟

LarsStegman · 2021-11-22T12:57:10Z

@simondale00 Could you update the PR to use 0.17.1?

Kludex · 2021-11-22T14:21:16Z

It really doesn't matter. @tiangolo will see the PR, and it will update it himself. Just wait for him to check this. 😗

narolski · 2021-11-30T07:42:06Z

@tiangolo I do see these exceptions raised a lot during our performance tests. Would you mind taking a look at this?

kevr · 2021-12-01T04:55:07Z

This time delay is kind of crazy.

pyproject.toml

sunshine-joe · 2021-12-03T12:36:17Z

I also got bug with starlette<0.17.0。
wating for this PR be merged , thanks

jerber · 2021-12-07T22:53:06Z

@tiangolo this causes a lot of errors on our server, would be great if you could merge!

narolski · 2021-12-16T14:48:51Z

@tiangolo sorry for bugging you again, but only today I have seen this exception raised over 100 times on my pre-prod environments. Is there any way I could help with upgrading the fastapi's dependencies?

hidaris · 2021-12-17T01:44:33Z

@tiangolo sorry for bugging you again, but only today I have seen this exception raised over 100 times on my pre-prod environments. Is there any way I could help with upgrading the fastapi's dependencies?

Maybe you can contact him on twitter, if the problem is really urgent

kevr · 2021-12-17T01:54:25Z

Maybe you can contact him on twitter, if the problem is really urgent

It's been urgent for about a month and a half now; check out the backlog of the issue.

narolski · 2021-12-21T11:20:46Z

@tiangolo sorry for bugging you again, but only today I have seen this exception raised over 100 times on my pre-prod environments. Is there any way I could help with upgrading the fastapi's dependencies?

Maybe you can contact him on twitter, if the problem is really urgent

I've reached out via DM on Twitter, will let you know here should I get a response. Is there anyone else who can help out in the meantime?

codecov · 2021-12-22T13:07:38Z

Codecov Report

Merging #4145 (dbb2599) into master (58ab733) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #4145   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          409       409           
  Lines        10264     10270    +6     
=========================================
+ Hits         10264     10270    +6

Impacted Files	Coverage Δ
...test_tutorial/test_dataclasses/test_tutorial002.py	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58ab733...dbb2599. Read the comment docs.

Co-authored-by: Dima Tisnek <dimaqq@gmail.com>

github-actions · 2021-12-22T13:19:06Z

📝 Docs preview for commit dbb2599 at: https://61c32593f3060d161428c7ba--fastapi.netlify.app

samuelcolvin

I've tested this on a big project and everything seems to be working great

installed with

pip install git+https://github.com/tiangolo/fastapi.git@refs/pull/4145/merge

@tiangolo LGTM

jerber · 2022-01-05T19:54:40Z

@tiangolo could you merge this? Our production app has been getting a ton of errors a day

dimaqq · 2022-01-05T23:08:18Z

Looks like this project needs a backup maintainer

dimaqq · 2022-01-05T23:13:14Z

#4263

tiangolo · 2022-01-07T09:35:39Z

Thanks @simondale00! 🚀

And thanks a lot @Kludex and @samuelcolvin! Your help is very much appreciated. 🙇 🍰 😎

tiangolo · 2022-01-07T17:14:34Z

This is now available in FastAPI 0.71.0. 🔖🚀

samuelcolvin · 2022-01-07T19:11:53Z

Thanks so much @tiangolo.

Redict · 2022-01-15T03:44:26Z

@tiangolo when it will be uploaded to pip?

simondale00 · 2022-01-15T04:08:09Z

@tiangolo when it will be uploaded to pip?

@Redict It's already available on PyPI: https://pypi.org/project/fastapi/0.71.0/#history

ashkan-hadadi · 2022-02-26T12:30:33Z

https://stackoverflow.com/questions/71222144/runtimeerror-no-response-returned-in-fast-api-when-refresh-request

The problem is still alive! please refer to above link @tiangolo

alex-pobeditel-2004 · 2022-05-18T21:21:30Z

Hello @ashkan-hadadi!
Is this issue still bothering you?
Right now I'm stuck on FastAPI 0.75 (released on March, 5) and issue persists there. But it's interesting for me if it was solved in next versions? Looks like FastAPI got many Starlette updates recently.

jkinkead · 2022-05-18T22:13:52Z

@alex-pobeditel-2004 - I'm still seeing the behavior as described in this bug on the latest version, so I think it's still an open issue.

kozhushman · 2022-05-26T10:55:37Z

Im using fastapi = 0.78.0 and still facing this issue, sadly

alex-pobeditel-2004 · 2022-05-26T11:33:12Z

Looks like another fix for it will arrive with next Starlette release:
encode/starlette#1634

adam-flyr · 2022-05-27T13:18:38Z

I'm having the same issue here. Noticed that I started to happen after I changed from axios < 0.22 to 0.22. I was using cancelToken before, and AbortController now.

teamhide · 2022-06-09T13:06:17Z

any update?

Kludex · 2022-06-09T13:07:47Z

any update?

? 🤔

Ki6an · 2022-07-15T09:26:08Z

still facing the issue in fastapi = 0.79.0

Kludex · 2022-07-15T09:47:53Z

This issue was solved.

If you have an issue that looks like the same, feel free to report as a discussion on the Starlette repository.

The BaseHTTPMiddleware logic is implemented on Starlette.

acjh · 2022-07-15T10:41:43Z

Discussion on the Starlette repository: encode/starlette#1527

Co-authored-by: Dima Tisnek <dimaqq@gmail.com> Co-authored-by: simond <simond@surveymonkey.com> Co-authored-by: Samuel Colvin <s@muelcolvin.com> Co-authored-by: Samuel Colvin <samcolvin@gmail.com>

Upgrade Starlette to 0.17.0

5d2d79e

nkamali approved these changes Nov 4, 2021

View reviewed changes

ehiggs mentioned this pull request Nov 7, 2021

starlette < 0.17.0 doesn't give exception tracebacks when testing app #4154

Closed

9 tasks

alexiri mentioned this pull request Nov 10, 2021

Unable to catch Exception via exception_handlers since FastAPI 0.70.0 #4025

Closed

9 tasks

dimaqq approved these changes Dec 2, 2021

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

narolski approved these changes Dec 20, 2021

View reviewed changes

samuelcolvin changed the title ~~⬆️ Upgrade Starlette to 0.17.0~~ ⬆️ Upgrade Starlette to 0.17.1 Dec 22, 2021

bump

4d8eb3e

samuelcolvin and others added 3 commits December 22, 2021 13:08

grade starlette to 0.17.1

3ab52bd

Co-authored-by: Dima Tisnek <dimaqq@gmail.com>

fix formatting 🙃

5791fa9

fix formatting 🙃

dbb2599

samuelcolvin mentioned this pull request Dec 22, 2021

new test client to support new starlette samuelcolvin/foxglove#19

Merged

samuelcolvin approved these changes Dec 22, 2021

View reviewed changes

tiangolo merged commit 2b10ca1 into tiangolo:master Jan 7, 2022

simondale00 deleted the upgrade-starlette-0.17.0 branch January 7, 2022 12:27

alexiri mentioned this pull request Jan 11, 2022

🙏 Find maintainers for FastAPI #4263

Closed

9 tasks

⬆️ Upgrade Starlette to 0.17.1 #4145

⬆️ Upgrade Starlette to 0.17.1 #4145

Conversation

simondale00 commented Nov 4, 2021

nkamali commented Nov 4, 2021

nkamali left a comment

Choose a reason for hiding this comment

simondale00 commented Nov 8, 2021

Kludex commented Nov 8, 2021

kevr commented Nov 9, 2021

Kludex commented Nov 9, 2021

robertlagrant commented Nov 9, 2021

simondale00 commented Nov 9, 2021

Kludex commented Nov 9, 2021

adriangb commented Nov 9, 2021

LarsStegman commented Nov 17, 2021

yezz123 commented Nov 17, 2021

LarsStegman commented Nov 22, 2021

Kludex commented Nov 22, 2021

narolski commented Nov 30, 2021

kevr commented Dec 1, 2021

sunshine-joe commented Dec 3, 2021

jerber commented Dec 7, 2021

narolski commented Dec 16, 2021

hidaris commented Dec 17, 2021

kevr commented Dec 17, 2021

narolski commented Dec 21, 2021

codecov bot commented Dec 22, 2021 • edited

Codecov Report

github-actions bot commented Dec 22, 2021

samuelcolvin left a comment

Choose a reason for hiding this comment

jerber commented Jan 5, 2022

dimaqq commented Jan 5, 2022

dimaqq commented Jan 5, 2022

tiangolo commented Jan 7, 2022

tiangolo commented Jan 7, 2022

samuelcolvin commented Jan 7, 2022

Redict commented Jan 15, 2022

simondale00 commented Jan 15, 2022

ashkan-hadadi commented Feb 26, 2022 • edited

alex-pobeditel-2004 commented May 18, 2022

jkinkead commented May 18, 2022

kozhushman commented May 26, 2022

alex-pobeditel-2004 commented May 26, 2022

adam-flyr commented May 27, 2022

teamhide commented Jun 9, 2022

Kludex commented Jun 9, 2022

Ki6an commented Jul 15, 2022 • edited

Kludex commented Jul 15, 2022

acjh commented Jul 15, 2022

codecov bot commented Dec 22, 2021 •

edited

ashkan-hadadi commented Feb 26, 2022 •

edited

Ki6an commented Jul 15, 2022 •

edited