Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Add external link to blog post about Kafka, FastAPI, and Ably #4044

Merged
merged 2 commits into from May 10, 2022

Conversation

Ugbot
Copy link
Contributor

@Ugbot Ugbot commented Oct 13, 2021

added my blog to the list of links, its about using FastAPI with Kafka and ably

added my blog to the list of links, its about using FastAPI with Kafka and ably
Copy link
Contributor

@ArcLightSlavik ArcLightSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change name of PR to: Added article about ticket booking with FastAPI and Kafka
Comments below are nitpicks, seems like a good article.

class Conference(BaseModel):
    eventId: str
    eventCapacity: int
    eventDate: int
    bookingStart: int
    bookingEnd: int
    timestamp: int
    pass

remove the 'pass'

@app.post('/inbound-conferences')
async def conference_creation(data: Conference, request: Request):
    try:
        conference_producer.produce(conference_topic, None, data.dict())
        conference_producer.poll(0)
        conference_producer.flush()
        print(data.dict())
    except Exception as e:
        print(e)
        return 400
   return 200

request isn't being used

@tiangolo tiangolo changed the title added my blog to the list of external links 📝 Add external link to blog post about Kafka, FastAPI, and Ably May 10, 2022
@tiangolo tiangolo enabled auto-merge (squash) May 10, 2022 01:19
@tiangolo
Copy link
Owner

Cool, thanks!

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #4044 (6f323d7) into master (fa1ffa5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #4044   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          531       531           
  Lines        13629     13629           
=========================================
  Hits         13629     13629           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa1ffa5...6f323d7. Read the comment docs.

@tiangolo tiangolo merged commit 8f90e51 into tiangolo:master May 10, 2022
JeanArhancet pushed a commit to JeanArhancet/fastapi that referenced this pull request Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants