Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Russian translation for docs/tutorial/first-steps.md #3562

Closed
wants to merge 10 commits into from

Conversation

solomein-sv
Copy link
Contributor

Соломеин Сергей added 2 commits July 20, 2021 15:47
@tiangolo tiangolo changed the title Add Russian translation for Tutorial Index and First Steps 🌐 Add Russian translation for docs/tutorial/first-steps.md Jul 21, 2021
@tiangolo tiangolo added awaiting-review lang-all Translations lang-ru Russian translations labels Jul 21, 2021
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #3562 (54e1718) into master (8cc6f9b) will not change coverage.
The diff coverage is n/a.

❗ Current head 54e1718 differs from pull request most recent head d25ffc6. Consider uploading reports for the commit d25ffc6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master     #3562   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          254       254           
  Lines         7860      7855    -5     
=========================================
- Hits          7860      7855    -5     
Impacted Files Coverage Δ
tests/test_response_model_include_exclude.py 100.00% <0.00%> (ø)
...st_tutorial/test_request_files/test_tutorial001.py 100.00% <0.00%> (ø)
...st_tutorial/test_request_files/test_tutorial002.py 100.00% <0.00%> (ø)
...l/test_request_forms_and_files/test_tutorial001.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e721d04...d25ffc6. Read the comment docs.

@tiangolo
Copy link
Owner

Awesome! Thanks for the contribution! 🙇

It's probably better to separate both files in different PRs, that will make it easier for others to review them. Thanks!

@github-actions
Copy link
Contributor

📝 Docs preview for commit 54e1718 at: https://60f817a8254e0e21ac2f05c8--fastapi.netlify.app

@solomein-sv
Copy link
Contributor Author

@tiangolo , thanks. I'll keep that in mind.

docs/ru/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/first-steps.md Show resolved Hide resolved
Copy link
Contributor Author

@solomein-sv solomein-sv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kunansy , thank you for the proofreading and corrections

Copy link

@mrparalon mrparalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Короткие предложения проще читаются. Больше шансов, что новичок дочитает до конца и попробует

docs/ru/docs/tutorial/index.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/index.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/index.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/index.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/index.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/index.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/index.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/index.md Outdated Show resolved Hide resolved
solomein-sv and others added 7 commits August 5, 2021 15:51
Co-authored-by: mrparalon <mr.paralon@gmail.com>
Co-authored-by: mrparalon <mr.paralon@gmail.com>
Co-authored-by: mrparalon <mr.paralon@gmail.com>
Co-authored-by: mrparalon <mr.paralon@gmail.com>
Co-authored-by: mrparalon <mr.paralon@gmail.com>
Co-authored-by: mrparalon <mr.paralon@gmail.com>
Co-authored-by: mrparalon <mr.paralon@gmail.com>
@solomein-sv
Copy link
Contributor Author

@dukkee could you review? by the way, you are the contributor already, do you want to continue translating?

Copy link
Contributor Author

@solomein-sv solomein-sv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@tiangolo
Copy link
Owner

It seems this was translated at some point in another PR. So I'll close this one, but thanks for the effort! ☕

@tiangolo tiangolo closed this Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review lang-all Translations lang-ru Russian translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants