Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test on 3.10 #3558

Closed
wants to merge 14 commits into from
Closed

test on 3.10 #3558

wants to merge 14 commits into from

Conversation

graingert
Copy link
Contributor

/cc @Kludex

(running with warnings as error enabled)

@codecov
Copy link

codecov bot commented Jul 20, 2021 •
edited

Codecov Report

Merging #3558 (963270f) into master (c15f042) will not change coverage.
The diff coverage is n/a.

❗ Current head 963270f differs from pull request most recent head bc2b080. Consider uploading reports for the commit bc2b080 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master     #3558   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          409       409           
  Lines        10264     10264           
=========================================
  Hits         10264     10264

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c15f042...bc2b080. Read the comment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 0fb7efc at: https://60f6929ad8c7aaa8cda90674--fastapi.netlify.app

graingert
graingert commented Jul 20, 2021
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

📝 Docs preview for commit 0810bdb at: https://60f69631f85c5ba78e1e6cf2--fastapi.netlify.app

@Kludex
Copy link
Sponsor Collaborator

Kludex commented Jul 20, 2021

This branch was created on top of #2298 (just for reference).

I guess @tiangolo will want to merge them separately, so we can have two different commits on master: "Support 3.9" and "Support 3.10".

@graingert graingert changed the title feat: support python 3.9 feat: support python 3.9 and 3.10b4 Jul 20, 2021
@github-actions
Copy link
Contributor

📝 Docs preview for commit 074bbb8 at: https://60f69ba2bc3adfa875397f20--fastapi.netlify.app

@graingert graingert marked this pull request as ready for review July 20, 2021 10:00
graingert
graingert commented Jul 20, 2021
View reviewed changes
pyproject.toml Outdated
@@ -110,6 +111,7 @@ junit_family = "xunit2"
filterwarnings = [
"error",
'ignore:"@coroutine" decorator is deprecated since Python 3\.8, use "async def" instead:DeprecationWarning',
Copy link
Contributor Author

@graingert graingert Jul 20, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they threatened to remove @asyncio.coroutine in 3.10 but it's actually only just gone in 3.11

@github-actions
Copy link
Contributor

📝 Docs preview for commit 798aacd at: https://6103b01f4a903a5f1af02de7--fastapi.netlify.app

@graingert graingert changed the title feat: support python 3.9 and 3.10b4 test on 3.10b4 Aug 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2021

📝 Docs preview for commit aac84e3 at: https://6109025f5cf43519aae8661e--fastapi.netlify.app

graingert
graingert commented Sep 24, 2021
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
@graingert graingert changed the title test on 3.10b4 test on 3.10rc2 Sep 24, 2021
@github-actions
Copy link
Contributor

📝 Docs preview for commit 942e0b3 at: https://614e06ea6d258a08f68b3ca3--fastapi.netlify.app

graingert
graingert commented Oct 6, 2021
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
@graingert graingert changed the title test on 3.10rc2 test on 3.10 Oct 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2021

📝 Docs preview for commit bc2065c at: https://615dc8c6540f044820b0c294--fastapi.netlify.app

graingert
graingert commented Oct 6, 2021
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2021

📝 Docs preview for commit 963270f at: https://615dca151b340f49a1fb9e69--fastapi.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2021

📝 Docs preview for commit bc2b080 at: https://615dcd5972917d4456653ad8--fastapi.netlify.app

@graingert
Copy link
Contributor Author

closing in favour of https://github.com/tiangolo/fastapi/pull/3712/files

@graingert graingert closed this Oct 6, 2021
@graingert graingert deleted the bump/accept-new-python-version branch October 6, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@graingert @Kludex