Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add French translation for docs/async.md #3416

Merged
merged 14 commits into from Aug 18, 2021

Conversation

Smlep
Copy link
Contributor

@Smlep Smlep commented Jun 27, 2021

Hey everyone!

Here is the PR to translate the async await doc page section into french.
See the french translation tracking issue here.

Thanks for the reviews👌

@codecov
Copy link

codecov bot commented Jun 27, 2021

Codecov Report

Merging #3416 (3941130) into master (0a84d48) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            master     #3416    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          248       254     +6     
  Lines         7712      7860   +148     
==========================================
+ Hits          7712      7860   +148     
Impacted Files Coverage Δ
fastapi/routing.py 100.00% <0.00%> (ø)
fastapi/openapi/utils.py 100.00% <0.00%> (ø)
fastapi/openapi/models.py 100.00% <0.00%> (ø)
tests/test_tutorial/test_body/test_tutorial001.py 100.00% <0.00%> (ø)
..._tutorial/test_custom_response/test_tutorial006.py 100.00% <0.00%> (ø)
...tutorial/test_custom_response/test_tutorial006b.py 100.00% <0.00%> (ø)
...tutorial/test_custom_response/test_tutorial006c.py 100.00% <0.00%> (ø)
...tutorial/test_custom_response/test_tutorial009b.py 100.00% <0.00%> (ø)
tests/test_custom_schema_fields.py 100.00% <0.00%> (ø)
..._tutorial/test_custom_response/test_tutorial009.py 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd7bbae...3941130. Read the comment docs.

@tiangolo tiangolo added awaiting-review lang-all Translations lang-fr French translations labels Jul 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2021

📝 Docs preview for commit 1ca7b8d at: https://60df27b73a6af3f689aa1442--fastapi.netlify.app

docs/fr/docs/async.md Outdated Show resolved Hide resolved
docs/fr/docs/async.md Outdated Show resolved Hide resolved
docs/fr/docs/async.md Outdated Show resolved Hide resolved
docs/fr/docs/async.md Outdated Show resolved Hide resolved
docs/fr/docs/async.md Outdated Show resolved Hide resolved
docs/fr/docs/async.md Outdated Show resolved Hide resolved
docs/fr/docs/async.md Outdated Show resolved Hide resolved
docs/fr/docs/async.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2021

📝 Docs preview for commit 0d19780 at: https://60df39033a6af30c23aa10ea--fastapi.netlify.app

Copy link
Contributor

@Cajuteq Cajuteq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left comments on the section that could be better imo. It is great work overall and the suggested changes may not all be relevant.

docs/fr/docs/async.md Outdated Show resolved Hide resolved
docs/fr/docs/async.md Outdated Show resolved Hide resolved
docs/fr/docs/async.md Outdated Show resolved Hide resolved
docs/fr/docs/async.md Outdated Show resolved Hide resolved
docs/fr/docs/async.md Outdated Show resolved Hide resolved
docs/fr/docs/async.md Outdated Show resolved Hide resolved
docs/fr/docs/async.md Outdated Show resolved Hide resolved
docs/fr/docs/async.md Outdated Show resolved Hide resolved
docs/fr/docs/async.md Outdated Show resolved Hide resolved
docs/fr/docs/async.md Outdated Show resolved Hide resolved
Smlep and others added 11 commits July 17, 2021 15:50
Co-authored-by: Jacquet Corentin <corentin.jacquet@telecomnancy.net>
Co-authored-by: Jacquet Corentin <corentin.jacquet@telecomnancy.net>
Co-authored-by: Jacquet Corentin <corentin.jacquet@telecomnancy.net>
Co-authored-by: Jacquet Corentin <corentin.jacquet@telecomnancy.net>
Co-authored-by: Jacquet Corentin <corentin.jacquet@telecomnancy.net>
Co-authored-by: Jacquet Corentin <corentin.jacquet@telecomnancy.net>
Co-authored-by: Jacquet Corentin <corentin.jacquet@telecomnancy.net>
Co-authored-by: Jacquet Corentin <corentin.jacquet@telecomnancy.net>
Co-authored-by: Jacquet Corentin <corentin.jacquet@telecomnancy.net>
Co-authored-by: Jacquet Corentin <corentin.jacquet@telecomnancy.net>
@github-actions
Copy link
Contributor

📝 Docs preview for commit 3941130 at: https://60f2e18cbf06fe05643565ab--fastapi.netlify.app

@Smlep
Copy link
Contributor Author

Smlep commented Aug 10, 2021

@Cajuteq I've updated the PR according to your suggestions, if everything's fine with you now you can approve the PR.

@tiangolo
Copy link
Owner

Awesome, thank you @Smlep! 🚀

And thank you for the reviews @Cajuteq and @rjNemo 🙇

@tiangolo tiangolo changed the title 🌐 Add French translation for Concurrency and async / await 🌐 Add French translation for docs/async.md Aug 18, 2021
@tiangolo tiangolo merged commit cb5b4e1 into tiangolo:master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-fr French translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants