Fix attempt to relative import in 'Testing' code examples #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📝 Docs preview for commit 815153f at: https://60ca644a9f310800cfdc5a9d--fastapi.netlify.app |
ArcLightSlavik
suggested changes
Jun 17, 2021
There was a problem hiding this comment.
We use relative explicit relative import everywhere in the docs, so we need to either change it everywhere or add a diagram like here: https://fastapi.tiangolo.com/tutorial/sql-databases/#file-structure
Also would require fixing a lot of tests.
|
Thanks for the effort! I handled it here: #5302 I'll close this one now. 🍰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue in documentation example code #3381