Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃搶 Pin SQLAlchemy range for tests, as it doesn't use SemVer #3001

Merged
merged 1 commit into from Mar 27, 2021

Conversation

tiangolo
Copy link
Owner

馃搶 Pin SQLAlchemy range for tests, as it doesn't use SemVer and I forgot (or didn't know?) that when I pinned it the first time.

This only affects FastAPI internal tests... and by accident, Pydantic tests. 馃槵 馃檲

@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #3001 (a72827b) into master (4d208b2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #3001   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          243       243           
  Lines         7419      7419           
=========================================
  Hits          7419      7419           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update c09e950...a72827b. Read the comment docs.

@github-actions github-actions bot temporarily deployed to commit March 27, 2021 16:35 Inactive
@github-actions
Copy link
Contributor

@tiangolo tiangolo merged commit 36721d4 into master Mar 27, 2021
@tiangolo tiangolo deleted the pin-sqlalchemy branch March 27, 2021 16:36
@Kludex
Copy link
Sponsor Collaborator

Kludex commented Mar 27, 2021

databases already solved this issue, discussions: #2996 and encode/databases#299

@tiangolo
Copy link
Owner Author

Thanks @Kludex for the heads up! I was convinced FastAPI was also affected as it has a direct dependency on SQLAlchemy and it had a too-open range (given SQLAlchemy doesn't follow SemVer). But now I realize that probably none of the code in FastAPI itself was really affected by the new SQLAlchemy release. 馃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants