Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed python 3.8.7 compatibility #2798

Closed
wants to merge 1 commit into from
Closed

Fixed python 3.8.7 compatibility #2798

wants to merge 1 commit into from

Conversation

vinayinvicible
Copy link

  • Upgraded starlette to 0.14.2
  • Added UJSONResponse into the project for backward compatibility

Ref: encode/starlette#1126, encode/starlette#901

* Upgraded starlette to 0.14.2
* Added UJSONResponse into the project
@ycd
Copy link
Contributor

ycd commented Feb 12, 2021

Duplicate of #2335.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 50d7072 at: https://6026a7e0751b7600919e376d--fastapi.netlify.app

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #2798 (50d7072) into master (a7a353e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2798   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          243       244    +1     
  Lines         7419      7437   +18     
=========================================
+ Hits          7419      7437   +18     
Impacted Files Coverage Δ
fastapi/responses.py 100.00% <100.00%> (ø)
..._tutorial/test_custom_response/test_tutorial001.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33be5fc...50d7072. Read the comment docs.

@vinayinvicible
Copy link
Author

@ycd
sorry my bad

@tiangolo
Copy link
Owner

Thanks for the help here @ycd ! 👏 🙇

Thanks for reporting back and closing it @vinayinvicible 👍

Sorry for the long delay! 🙈 I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants