Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Korean translation for Tutorial - Header Parameters #2589

Merged
merged 3 commits into from Mar 27, 2021
Merged

🌐 Add Korean translation for Tutorial - Header Parameters #2589

merged 3 commits into from Mar 27, 2021

Conversation

mode9
Copy link
Contributor

@mode9 mode9 commented Jan 1, 2021 •
edited

Hello, there.

I've referred to the previous translation Pull Requests.

Please let me know if any problems.

This PR translates tutorial/header-params.md in Korean.

related: #2017

@codecov
Copy link

codecov bot commented Jan 1, 2021 •
edited

Codecov Report

Merging #2589 (18e1cb3) into master (66f18e9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2589   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          243       243           
  Lines         7419      7419           
=========================================
  Hits          7419      7419

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 650abf0...18e1cb3. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2021

📝 Docs preview for commit 9b8f848 at: https://5fef03922e91f88a5f5d17fa--fastapi.netlify.app

@mode9 mode9 changed the title translate tutorial/header-params.md Add Korean translation for Tutorial - Header Parameters Jan 1, 2021
@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Jan 5, 2021
hard-coders
hard-coders suggested changes Feb 7, 2021
View reviewed changes
docs/ko/docs/tutorial/header-params.md Outdated
@@ -0,0 +1,90 @@
# 헤더 매개변수

헤더 파라미터를 `Query`, `Path` 그리고 `Cookie` 파라미터들과 같은 방식으로 정의할 수 있습니다.
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
헤더 파라미터를 `Query`, `Path` 그리고 `Cookie` 파라미터들과 같은 방식으로 정의할 수 있습니다.
헤더 매개변수를 `Query`, `Path` 그리고 `Cookie` 매개변수들과 같은 방식으로 정의할 수 있습니다.

docs/ko/docs/tutorial/header-params.md Outdated

## `Header` 임포트

먼저 `Header`를 임포트합니다.:
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
먼저 `Header`를 임포트합니다.:
먼저 `Header`를 임포트합니다:

docs/ko/docs/tutorial/header-params.md Outdated

## `Header` 매개변수 선언

`Path`, `Query` 그리고 `Cookie`를 사용한 동일한 구조를 이용하여 헤더 파라미터를 선언합니다.
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`Path`, `Query` 그리고 `Cookie`를 사용한 동일한 구조를 이용하여 헤더 파라미터를 선언합니다.
`Path`, `Query` 그리고 `Cookie`를 사용한 동일한 구조를 이용하여 헤더 매개변수를 선언합니다.

docs/ko/docs/tutorial/header-params.md Outdated

## 중복 헤더

값이 여러개인 동일한 헤더를 수신할 수 있습니다.
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original was:

It is possible to receive duplicate headers. That means, the same header with multiple values.
Suggested change
값이 여러개인 동일한 헤더를 수신할 수 있습니다.
중복 헤더들을 수신 할 수 있습니다. 즉, 다중값을 갖는 동일한 헤더를 뜻합니다.

It's really nice and natural🤩, but we should not break a sentence structure as much as possible. I also mentioned it in another review because we have to preserve the original author's intentions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. You're right. I think I made a mistake.

@mode9
Modified what requested changes.
efd0ff5 
1. parameters word.
2. Modified the translation sentence to the same structure as the original sentence.
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2021

📝 Docs preview for commit efd0ff5 at: https://60200d293c2ab5b20a7e6943--fastapi.netlify.app

hard-coders
hard-coders approved these changes Feb 7, 2021
View reviewed changes
Copy link
Sponsor Contributor

@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks for your contribution.

@mode9 mode9 changed the title Add Korean translation for Tutorial - Header Parameters 🌐 Add Korean translation for Tutorial - Header Parameters Feb 14, 2021
@mode9 mode9 changed the title 🌐 Add Korean translation for Tutorial - Header Parameters 🌐 🇰🇷 Add Korean translation for Tutorial - Header Parameters Feb 14, 2021
PandaHun
PandaHun approved these changes Feb 20, 2021
View reviewed changes
Copy link
Contributor

@PandaHun PandaHun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's perfectly done

@tiangolo tiangolo changed the title 🌐 🇰🇷 Add Korean translation for Tutorial - Header Parameters 🌐 Add Korean translation for Tutorial - Header Parameters Mar 27, 2021
@tiangolo
Copy link
Owner

Thanks for your contribution @mode9 ! 👏 🎉

And thanks for the reviews @PandaHun and @hard-coders ! 🍰

@tiangolo tiangolo merged commit 5934a75 into tiangolo:master Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hard-coders hard-coders hard-coders approved these changes

@PandaHun PandaHun PandaHun approved these changes

Assignees
No one assigned
Labels
approved-2 lang-all Translations lang-ko Korean translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mode9 @tiangolo @hard-coders @PandaHun