Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update starlette to ~=0.14 #2569

Closed
wants to merge 1 commit into from

Conversation

dhirschfeld
Copy link

Just seeing if there is any appetite to:

  1. Update the starlette pin
  2. Loosen the exact pinning

@github-actions
Copy link
Contributor

📝 Docs preview for commit 0b4b0e7 at: https://5fe427eb69f90dbff37cd5dd--fastapi.netlify.app

@Mause
Copy link
Contributor

Mause commented Dec 24, 2020

This is a duplicate of #2335

@dhirschfeld
Copy link
Author

Looks like it's not compatible due to the removal to UJSONResponse:

fastapi/responses.py:10: error: Module 'starlette.responses' has no attribute 'UJSONResponse'; maybe "JSONResponse" or "Response"?

xref: https://github.com/encode/starlette/releases/tag/0.14.1

@dhirschfeld
Copy link
Author

This is a duplicate

So, it is - sorry should have searched first!

I still think there's value in relaxing the exact pinning so wanted to check if @tiangolo had changed his position since #1555?

@dhirschfeld dhirschfeld deleted the update-starlette branch December 25, 2020 02:32
@tiangolo
Copy link
Owner

tiangolo commented Nov 9, 2022

Thanks for the discussion! 🍰

And nope, I can't relax the pin yet, there have been constant/recent breaking changes. And in fact, the current pin on Starlette allows Starlette to move more easily without worrying a lot about breaking stuff between versions and having to deal with a lot of backwards compatibility between versions. That problem will probably come later after the first 1.x versions, but for now, it's better to try to structure the code the best way possible before getting into those new problems... 🤓

Sorry for the long delay! 🙈 I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants