Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃帹 Remove internal "type: ignore", now unnecessary #2424

Merged
merged 1 commit into from Feb 7, 2021
Merged

馃帹 Remove internal "type: ignore", now unnecessary #2424

merged 1 commit into from Feb 7, 2021

Conversation

AsakuraMizu
Copy link
Contributor

pydantic/pydantic#1739

This bug is fixed.

@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #2424 (29e6de3) into master (cc99e23) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2424   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          240       240           
  Lines         7101      7101           
=========================================
  Hits          7101      7101           
Impacted Files Coverage 螖
fastapi/dependencies/utils.py 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update d550738...29e6de3. Read the comment docs.

@github-actions
Copy link
Contributor

馃摑 Docs preview for commit 29e6de3 at: https://5fbf673799a34e39eb692583--fastapi.netlify.app

Copy link
Sponsor Collaborator

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 馃帀

@tiangolo tiangolo changed the title Remove type: ignore 馃帹 Remove internal "type: ignore", now unnecessary Feb 7, 2021
@tiangolo tiangolo merged commit f221373 into tiangolo:master Feb 7, 2021
@tiangolo
Copy link
Owner

tiangolo commented Feb 7, 2021

Awesome! Thanks @AsakuraMizu ! 馃殌 馃攳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants