Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃寪 Add Korean translation for Tutorial - Path Parameters #2355

Merged
merged 4 commits into from May 4, 2021
Merged

馃寪 Add Korean translation for Tutorial - Path Parameters #2355

merged 4 commits into from May 4, 2021

Conversation

hard-coders
Copy link
Sponsor Contributor

This PR translates tutorial/path-params.md in Korean.

related: #2017

@codecov
Copy link

codecov bot commented Nov 15, 2020 •
edited

Codecov Report

Merging #2355 (d62c16d) into master (6f72a27) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2355   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          243       243           
  Lines         7419      7419           
=========================================
  Hits          7419      7419

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 10397dd...d62c16d. Read the comment docs.

@github-actions
Copy link
Contributor

馃摑 Docs preview for commit a119738a5b5f896b821e0da41738852c0906e062 at: https://5fb0fb5a5a29020c2132e877--fastapi.netlify.app

@github-actions
Copy link
Contributor

馃摑 Docs preview for commit 948ff1f5a9fa91ad7ddfe00c9f17dbc4fd53ab5e at: https://5fb8d348ec6a9b1ac21f5e20--fastapi.netlify.app

@github-actions
Copy link
Contributor

馃摑 Docs preview for commit 9085ce61ecfe7ae5ae43172d0dd9051c94e79199 at: https://5fb8df88ec6a9b30651f5fe7--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Nov 25, 2020
PandaHun
PandaHun reviewed Dec 17, 2020
View reviewed changes
Copy link
Contributor

@PandaHun PandaHun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's almost there!

docs/ko/docs/tutorial/path-params.md Show resolved Hide resolved
docs/ko/docs/tutorial/path-params.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

馃摑 Docs preview for commit d62c16d at: https://606079eb5d5dcb1001e9a337--fastapi.netlify.app

@hard-coders
Copy link
Sponsor Contributor Author

@PandaHun It's been a while. Could you review and approve it?

@tiangolo
Copy link
Owner

tiangolo commented May 4, 2021

Thanks a lot @hard-coders ! 馃殌 馃崻

And thanks for the reviews @baek9652, @PandaHun, @Suyoung789 ! 馃檱

@tiangolo tiangolo merged commit 462014e into tiangolo:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxlok-3564 xxlok-3564 xxlok-3564 approved these changes

@PandaHun PandaHun PandaHun approved these changes

@Suyoung789 Suyoung789 Suyoung789 approved these changes

Assignees
No one assigned
Labels
approved-2 lang-all Translations lang-ko Korean translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hard-coders @tiangolo @xxlok-3564 @PandaHun @Suyoung789