Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摑 Add external link to "FastAPI for Flask Users" #2280

Merged
merged 3 commits into from Feb 7, 2021

Conversation

amitness
Copy link
Contributor

@amitness amitness commented Nov 1, 2020

I have added a link to my article FastAPI for Flask Users in the external links section of documentation.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2020

馃摑 Docs preview for commit 5ec2a34 at: https://5f9e8ff8a392bfc00adfcd35--fastapi.netlify.app

Copy link
Contributor

@ycd ycd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have an alphabetical order. The order is first-come-first-serve, so to be fair, please add this to the end.

@amitness
Copy link
Contributor Author

amitness commented Nov 2, 2020

@ycd I've migrated it to the end of the list. Should adhere to the FCFS rule now.

@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #2280 (a748ba1) into master (7d7289a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2280   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          240       240           
  Lines         7101      7101           
=========================================
  Hits          7101      7101           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update b53c443...a748ba1. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2020

馃摑 Docs preview for commit c7de6f2 at: https://5f9fa7c380012668801451a6--fastapi.netlify.app

@github-actions
Copy link
Contributor

馃摑 Docs preview for commit a748ba1 at: https://5fba5d3f2c6b3e94a6fe348c--fastapi.netlify.app

@amitness
Copy link
Contributor Author

@ycd I've fixed the merge conflicts. Can you look into it now?

@ycd
Copy link
Contributor

ycd commented Nov 22, 2020

Thanks, actually, you don't have to change the order, since your PR is older than the latest one, FYI.

@amitness
Copy link
Contributor Author

@ycd I've no problems with the ordering. Let's merge it the way it is.

@tiangolo tiangolo changed the title Add "FastAPI for Flask Users" 馃摑 Add external link to "FastAPI for Flask Users" Feb 7, 2021
@tiangolo
Copy link
Owner

tiangolo commented Feb 7, 2021

Thanks @amitness ! Great article! 馃憦 馃憦

And thanks @ycd for the help. 馃檱 馃嵃

@tiangolo tiangolo merged commit 6b6a310 into tiangolo:master Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants