New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Check Content-Type request header before assuming JSON #2118
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e46bce3
Check Content-Type before assuming JSON
df4fdf0
Remove now-unneccessary exception handling
4e8605e
Fix broken-body test
c7191f5
Assume "Content-Type": "application/octet-stream"
c169258
Explicitly specify Content-Type in gzip test
d644c30
Interpret as JSON any mimetype ending with "json"
6ecfba9
Generalize media type parsing to handle parameters
d752efd
Add test for handling various Content-Type headers
patrickkwang f80305d
✅ Update tests for content-type headers and include extra corner case
tiangolo 344ae3f
♻️ Re-implement JSON content-type parsing with Python's standard libr…
tiangolo 29257d0
🔀 Merge master to update codebase, dependencies and tests
tiangolo 5729e8a
✅ Include again test with patch to force exception, for coverage
tiangolo File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be considered a breaking change. Think even my work API has a test similar to this.