-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a WebSocketAPIRoute class to support #166 #178
Conversation
…ments to a websocket callable, initial testing for headers
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
==========================================
- Coverage 100% 99.95% -0.05%
==========================================
Files 164 164
Lines 4035 4079 +44
==========================================
+ Hits 4035 4077 +42
- Misses 0 2 +2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
======================================
Coverage 100% 100%
======================================
Files 164 181 +17
Lines 4035 4500 +465
======================================
+ Hits 4035 4500 +465
Continue to review full report at Codecov.
|
Nice! I'll review it soon. |
I have a few more things I could add to the PR that we are using internally. i.e. pydantic validated message types for websocket input/output. But I am not sure if others would find that functionality useful. |
Sounds very interesting. I think we could have some optional mechanism to do it (not enforcing it on all cases). How does it look like? I mean, the code a developer writes using your extensions. |
I will try to put together a sample project soon™ ... |
Circling back on this, been in our backlog. Semi tricky to separate out the functionality, but haven't forgotten about it! |
Cool! I just refactored this PR a bit, added docs, updated tests and merged. I also started encode/starlette#527. Once (and if) it is accepted, it will allow us to This is just released in version I'll update the internals to include encode/starlette#527 later, but this works already. Thanks a lot for your work! 🎉 🚀 🌮 |
Initial work at adding dependencies to websocket routes (see #166 ). The way I added it in is probably less than ideal, but figured I would open the PR for now. Still to be done is adding in tests for other dependencies such as Security, Query, Cookie, etc...