squash __root__ in BaseModel json encoding #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1524 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 227 227
Lines 6810 6817 +7
=========================================
+ Hits 6810 6817 +7
Continue to review full report at Codecov.
|
|
Nice, thank you! 🐛 🔥 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #911.
This corrects the specific problem described by @peku33, where the response is received by the client as
{"__root__": foo}. This change simply converts tofooduring json encoding.Note that these
__root__structures may still exist internally, e.g.{"foo": {"__root__": foo}}. That is a pydantic bug (pydantic/pydantic#1414) with an open PR.