Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix evaluating stringified annotations in Python 3.10 #11355

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chaen
Copy link

@chaen chaen commented Mar 27, 2024

I've bumped into the exact same issue as tiangolo/typer#598 so I solved it like tiangolo/typer#721 😄

I'll try to add tests soon but if you can do it faster, please feel free !!

@chaen
Copy link
Author

chaen commented Mar 27, 2024

So frankly, I am not sure which one of the multiple options my issue is, maybe even a mixture of all of that:

So I am not even sure that this fix is correct, but it definitely fixes my issues.
I took the tests reported in 2 of the issues, added them as unit tests, and it fixes it. But again, I am not completely sure this is correct :-)

@tiangolo tiangolo added bug Something isn't working p2 labels Apr 2, 2024
@chaen
Copy link
Author

chaen commented May 8, 2024

hi @tiangolo I checked the #10370 roadmap but it isn't entirely clear to me the timescale we are talking about for that PR or all those marked p2 ? Let me know if there's anything I still need to do here :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants