🐛 Fix openapi generation with responses kwarg #10895
Open
+27
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flxdot
changed the title
flxdot
force-pushed
the
bugfix/responses-model-openapi
branch
from
73235ab
to
c166a96
Compare
flxdot
force-pushed
the
bugfix/responses-model-openapi
branch
from
684ae92
to
b5d733e
Compare
tiangolo
added
bug
YuriiMotov
approved these changes
Feb 16, 2024
|
I am also affected by this issue. Is this PR ready to be merged? |
From my point of view, it is. @tiangolo is there anything else you need me to do here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the schema of response models defined via the
responseskeyword where generated asvalidationschema instead ofserializationschema.Additional discussions for that topic: