-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chinese translation #1060
Chinese translation #1060
Conversation
中文翻译文档-index
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is the proper way to merge translations into master by removing all the original sentences.
I don't even know if the documentation even supports having translations with the way is is setup right now; not to mention that translating all of it would be a huge endeavor. I know FastAPI has contributors from a variety of countries speaking a variety of languages, but I guess English has done a good enough job at getting everyone involved to understand each other so far, so it's not a priority for anyone at the moment. EDIT: Nevermind, hadn't noticed #1055 yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't do a full review, but there are some inaccuracies, many references to 3rd party images that are not guaranteed to be immutable, many of the helpful additional comments have been removed. Most importantly, rewriting the index.md is not ideal, (IMHO) this translation is probably better left in a forked repo for other people to see if necessary.
<img src="https://badges.gitter.im/tiangolo/fastapi.svg" alt="Join the chat at https://gitter.im/tiangolo/fastapi"> | ||
</a> | ||
</p> | ||
![FastAPI](http://linupyoos.oss-cn-beijing.aliyuncs.com/blogs/2020-02-29-114916.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linking to a 3rd party image that may change any time doesn't seem like a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your comments. Recently, I learned a lot about Github.
* **Short**: Minimize code duplication. Multiple features from each parameter declaration. Fewer bugs. | ||
* **Robust**: Get production-ready code. With automatic interactive documentation. | ||
* **Standards-based**: Based on (and fully compatible with) the open standards for APIs: <a href="https://github.com/OAI/OpenAPI-Specification" class="external-link" target="_blank">OpenAPI</a> (previously known as Swagger) and <a href="http://json-schema.org/" class="external-link" target="_blank">JSON Schema</a>. | ||
FastAPI是一种现代的,快速的(高性能)的Web框架,基于标准Python类型提示构建的API,使用的Python的版本应该3.6+。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this translation is very good, FastAPI is not an API but a framework to build APIs, and the translation is quite much more informal than the original text.
- **快:** 与NodeJS和Go相当的高性能(感谢Starlette和Pydantic)。 [最快的Python框架之一](https://github.com/tiangolo/fastapi/blob/master/docs/index.md#performance) | ||
- **快速编码:** 开发速度提升2到3倍 | ||
- **更少的bug:** 减少约40%的人为原因导致的bug | ||
- **直观:** 强大的编辑器支持,更快完成,调试时间更少 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this rather be 自动完成?
|
||
--- | ||
|
||
"*Honestly, what you've built looks super solid and polished. In many ways, it's what I wanted **Hug** to be - it's really inspiring to see someone build that.*" | ||
老实说,你做的东西看起来很可靠和漂亮。从很多方面来说,这就是我希望**Hug**成为的样子。看到有人这么做,真的很鼓舞人心。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看到有人这么做 doesn't convey very well the point of someone building what Hug was supposed to be.
@@ -120,12 +101,9 @@ def read_item(item_id: int, q: str = None): | |||
return {"item_id": item_id, "q": q} | |||
``` | |||
|
|||
<details markdown="1"> | |||
<summary>Or use <code>async def</code>...</summary> | |||
如果您的代码使用了`async` / `await`,请使用 `async def` : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why the past tense in the former part of the sentence.
|
||
And now, go to <a href="http://127.0.0.1:8000/redoc" class="external-link" target="_blank">http://127.0.0.1:8000/redoc</a>. | ||
![ReDoc](http://linupyoos.oss-cn-beijing.aliyuncs.com/blogs/2020-02-29-135552.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More external images.
Thanks for your effort and contribution @linupychiang ! 🍰 🚀 And thanks a lot @juhovh-aiven for helping with the review ...and for keeping the review in English (that way I can understand the conversation 😅 ). @linupychiang I finally finished the set up to have translations for the docs, here are the new docs: https://fastapi.tiangolo.com/contributing/#translations You can probably still copy a lot of the text you had already translated, as the file structure is the same. |
FastAPI文档index部分中文翻译