Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Portuguese translation for docs/pt/docs/deployment/docker.md #5663

Merged
merged 8 commits into from Nov 27, 2022
Merged

🌐 Add Portuguese translation for docs/pt/docs/deployment/docker.md #5663

merged 8 commits into from Nov 27, 2022

Conversation

ayr-ton
Copy link
Contributor

@ayr-ton ayr-ton commented Nov 19, 2022 •
edited

There are some opportunities to update the original docker documentation but I will do that in a separated PR once this one is reviewed.

@ayr-ton ayr-ton mentioned this pull request Nov 19, 2022
Closed
@github-actions
Copy link
Contributor

📝 Docs preview for commit 3b00f6f at: https://637947c6ea25702ffc1536e6--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 31a65bd at: https://637949e19d407f337634905c--fastapi.netlify.app

@ayr-ton ayr-ton force-pushed the docs/pt-deployment-docker branch 2 times, most recently from dcedadb to 26301e7 Compare November 22, 2022 13:44
guites
guites suggested changes Nov 22, 2022
View reviewed changes
Copy link

@guites guites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great translation!

docs/pt/docs/deployment/docker.md Outdated Show resolved Hide resolved
docs/pt/docs/deployment/docker.md Outdated Show resolved Hide resolved
docs/pt/docs/deployment/docker.md Outdated Show resolved Hide resolved
docs/pt/docs/deployment/docker.md Outdated Show resolved Hide resolved
docs/pt/docs/deployment/docker.md Outdated Show resolved Hide resolved
docs/pt/docs/deployment/docker.md Outdated Show resolved Hide resolved
docs/pt/docs/deployment/docker.md Outdated Show resolved Hide resolved
docs/pt/docs/deployment/docker.md Outdated Show resolved Hide resolved
docs/pt/docs/deployment/docker.md Outdated Show resolved Hide resolved
docs/pt/docs/deployment/docker.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

📝 Docs preview for commit 2f13f4b at: https://637cd370ce97bd2089131c0a--fastapi.netlify.app

@ayr-ton ayr-ton force-pushed the docs/pt-deployment-docker branch 5 times, most recently from bcbc6ad to eff095f Compare November 22, 2022 14:05
@github-actions
Copy link
Contributor

📝 Docs preview for commit 8d98626 at: https://637cd86b5146b825bd329679--fastapi.netlify.app

@ayr-ton
Copy link
Contributor Author

ayr-ton commented Nov 22, 2022

@guites Thank you for your time reviewing! 😄

@github-actions
Copy link
Contributor

📝 Docs preview for commit 715c676 at: https://637cda5a2db5a7292bc631d8--fastapi.netlify.app

@tiangolo tiangolo added lang-all Translations lang-pt Portuguese translations awaiting-review labels Nov 23, 2022
guites
guites approved these changes Nov 23, 2022
View reviewed changes
Copy link

@guites guites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the author fixed all points except for a few nitpicks, which is ok.

izaguerreiro
izaguerreiro reviewed Nov 23, 2022
View reviewed changes
docs/pt/docs/deployment/docker.md Outdated Show resolved Hide resolved
docs/pt/docs/deployment/docker.md Outdated Show resolved Hide resolved
docs/pt/docs/deployment/docker.md Outdated Show resolved Hide resolved
docs/pt/docs/deployment/docker.md Outdated Show resolved Hide resolved
@ayr-ton
Copy link
Contributor Author

ayr-ton commented Nov 23, 2022

Thanks for your time reviewing! Working in @izaguerreiro suggestions and will let you know once is ready.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 017851f at: https://637eb15ea69c556e0f656597--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 81829ef at: https://637eb2b727e28360fbf48e93--fastapi.netlify.app

@ayr-ton
Copy link
Contributor Author

ayr-ton commented Nov 24, 2022

Ready

@github-actions
Copy link
Contributor

📝 Docs preview for commit 4426332 at: https://637f710d3f0ba606981921e6--fastapi.netlify.app

@ayr-ton
Copy link
Contributor Author

ayr-ton commented Nov 24, 2022

Missed the nitpicks.
Just fixed them, @guites o/
Thanks again

@github-actions
Copy link
Contributor

📝 Docs preview for commit 4426584 at: https://637fb44f89f6414c4fe8f264--fastapi.netlify.app

@ayr-ton
Copy link
Contributor Author

ayr-ton commented Nov 25, 2022

The PR #5680 seems to fix the libffi error that is breaking the build.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 22c4e9c at: https://63811d25adf1a06dc6911306--fastapi.netlify.app

@tiangolo tiangolo changed the title 🌐 Add Portuguese translation for deployment/docker.md 🌐 Add Portuguese translation for docs/pt/docs/deployment/docker.md Nov 27, 2022
@tiangolo
Copy link
Owner

Awesome, thank you! 🙇

And thanks a lot for the reviews @izaguerreiro and @guites ☕ 🍰

@tiangolo tiangolo enabled auto-merge (squash) November 27, 2022 14:04
@github-actions
Copy link
Contributor

📝 Docs preview for commit 688b45b at: https://63837073218017641c11a8a0--fastapi.netlify.app

@tiangolo tiangolo merged commit ebd917a into tiangolo:master Nov 27, 2022
@ayr-ton ayr-ton deleted the docs/pt-deployment-docker branch November 28, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izaguerreiro izaguerreiro izaguerreiro approved these changes

@guites guites guites approved these changes

Assignees
No one assigned
Labels
approved-2 lang-all Translations lang-pt Portuguese translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ayr-ton @tiangolo @izaguerreiro @guites