Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persian translations #2041

Closed
saeedesmaili opened this issue Sep 12, 2020 · 14 comments
Closed

Persian translations #2041

saeedesmaili opened this issue Sep 12, 2020 · 14 comments
Labels
feature New feature or request lang-all Translations lang-fa Persian translations

Comments

@saeedesmaili
Copy link

Description

I want to start translating the docs to Persian language and will track the progress here.

@saeedesmaili saeedesmaili added the feature New feature or request label Sep 12, 2020
@mosi-kha
Copy link

sounds good!

@Kludex
Copy link
Sponsor Collaborator

Kludex commented Nov 23, 2020

I'm going to ping the translations' coordination issue here: #1497 .
As we organize the translations there.

@tiangolo
Copy link
Owner

Awesome! I just added this issue to the pinned translations issue.

@meysam81
Copy link

@saeedesmaili
Need any help buddy? I'm game if you want a partner ✌️

@lnxpy
Copy link

lnxpy commented Oct 30, 2021

@saeedesmaili I'm also ready to contribute.

@onionj
Copy link

onionj commented Nov 26, 2021

I'm also ready to contribute. @saeedesmaili

@aminalaee
Copy link
Contributor

@Kludex Do you think you can merge this #2395 through so people can start the translations?

And for anyone else, I think when #2395 is merged, we can just pick one or some markdown files from English docs and start the translations and put them in the Persian docs folder, and create PRs for them.
I'm happy to contribute in translations and reviews.

@Kludex
Copy link
Sponsor Collaborator

Kludex commented Dec 3, 2021

I don't have merge rights on FastAPI. We'd need to wait for Sebastián to merge it.

What I recommend (so you don't are blocked) is to create branches on top of #2395, and when that is merged, rebase your branch.

@aminalaee
Copy link
Contributor

Thanks for the reply. Honestly I thought about that too, but since the base branch is already a year old, if that's not approved and needs changes then we'll need some modifications in all new branches.

@Kludex
Copy link
Sponsor Collaborator

Kludex commented Dec 3, 2021

Usually the first commit on a language translation doesn't have any translated pages. This PR has index.md translated, so that's maybe why it was not merged.

Even so, if that PR changes, each PR is minimal, only rebase will be needed without conflicts. If you feel like that PR is not going to be merged, for some reason (maybe changes are needed and author away), knowing that you're active on the community, maybe you should create the PR yourself (without the index.md being translated, only in English, like the other languages).

@zarinpy
Copy link

zarinpy commented Apr 21, 2022

@tiangolo what about the messages inside the framework, how we can translate them and make a pull request ?

@tiangolo tiangolo added lang-all Translations lang-fa Persian translations labels Oct 19, 2022
@tiangolo
Copy link
Owner

@zarinpy hmm, I think there are no messages inside the framework... what do you refer to?

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Good news everyone! 😉 There's a new translation PR to be reviewed: #5887 🎉

@NFEL
Copy link

NFEL commented Mar 3, 2023

@zarinpy hmm, I think there are no messages inside the framework... what do you refer to?

Error Handler messages, i assume .

@tiangolo tiangolo removed the reviewed label Mar 4, 2023
Repository owner locked and limited conversation to collaborators Mar 4, 2023
@tiangolo tiangolo converted this issue into discussion #9184 Mar 4, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
feature New feature or request lang-all Translations lang-fa Persian translations
Projects
None yet
Development

No branches or pull requests

10 participants