fix: generated id="root{n}" should be removed #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ahnpnl, do you think this PR is fine to approve? |
ahnpnl
reviewed
Oct 1, 2023
| @@ -9,7 +9,9 @@ exports[`snapshot should work 1`] = ` | |||
| > | |||
| <p> | |||
| Line 1 | |||
| </p><div> | |||
| </p><div | |||
There was a problem hiding this comment.
can we avoid not generating thisid?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using snapshot testing, Angular will generate
<div id="root{n}">root tag every time callTestBed.createComponent; this attribute will cause the snapshot not to be stable and should be removed when serializing content.Test plan
I have updated the testing snapshot content, fixed the code, and the snapshot testing passed.
Does this PR introduce a breaking change?
All old snapshots containing
<div id="root{n}">will cause failure.So developers have to update the new snapshot manually after the upgrade.
Other information