fix: add mock for BrowserAnimationsModule #206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
approved these changes
Nov 28, 2018
ahnpnl
approved these changes
Nov 28, 2018
|
Btw, can we add a small smoke test? |
Agree 👍 |
ahnpnl
added
the
Revision needed
|
@wtho is this still needed with jsdom@13 we use? FYI there's a new major version of jsdom, worth checking it as well :) |
|
It is already included in jsdom since vs 11.12, good catch! I also checked on version 13 and the properties are already set. Yeah, we can update jsdom on occasion, but there are no game-changing features/bugfixes in v14 as far as I can judge. |
|
Awesome! I'll close this PR then. Thanks @splincode! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed: #170