Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse S3 client #138

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Reuse S3 client #138

wants to merge 4 commits into from

Conversation

lukaswelte
Copy link

@lukaswelte lukaswelte commented Jul 19, 2023

Resolves #114

Due to the reuse of S3 clients we significantly increase the response time by around 200ms


I'm not a great python dev, so please bear with me if this is aweful python code

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

This PR is stale because it has been open 45 days with no activity. Remove the stale label or add a comment, or this PR will be closed in 10 days. You can always re-open if you feel this is something we should still keep working on. Tag @heynemann for more information.

@github-actions github-actions bot added the Stale label Oct 5, 2023
@github-actions
Copy link

This PR was closed because it has been stale for 10 days with no activity.

@github-actions github-actions bot closed this Oct 15, 2023
@guilhermef guilhermef reopened this Nov 1, 2023
@guilhermef guilhermef requested a review from a team as a code owner November 1, 2023 08:06
@guilhermef guilhermef self-requested a review November 1, 2023 08:06
@guilhermef guilhermef added do-not-reap Do not reap this as being stale. and removed Stale labels Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-reap Do not reap this as being stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lower performance compared to tc_aws
2 participants